2017-11-09 16:40 GMT+01:00 Leif Lindholm <leif.lindh...@linaro.org>:
> On Thu, Nov 09, 2017 at 04:16:54PM +0100, Marcin Wojtas wrote:
>> Hi Leif,
>>
>> > > + {
>> > > + MvFvbGetAttributes, // GetAttributes
>> > > + MvFvbSetAttributes, // SetAttributes
>> > > + MvFvbGetPhysicalAddress, // GetPhysicalAddress
>> > > + MvFvbGetBlockSize, // GetBlockSize
>> > > + MvFvbRead, // Read
>> > > + MvFvbWrite, // Write
>> > > + MvFvbEraseBlocks, // EraseBlocks
>> > > + NULL, // ParentHandle
>> > > + }, // FvbProtoccol;
>> >
>> > -c
>> >
>>
>> Thanks for thorough review. Everything seems clear, but what does "-c"
>> above mean?
>
> You stole the misspelt "// FvbProtocol" from
> ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c.
>
> This had the benefit of showing me what this file was based on, but
> should probably be fixed :)
>
Right, I could have mentioned it explicitly in the commit message
(only the copyrights are left). Significant part of the issues you
pointed had been inherited from the original driver - my eyes and the
checkpatch missed them.
Marcin
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
