On Fri, Nov 17, 2017 at 04:08:59PM +0000, Ard Biesheuvel wrote: > Remove dependencies on gArmTokenSpaceGuid.PcdSystemMemoryBase and > gArmTokenSpaceGuid.PcdSystemMemorySize, the presence of which in > a [FixedPcd] section makes this module unusable for ArmVirtQemu. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
Question: shouldn't specifically ArmVirtQemu work fine with these, since it defines them as PcdsFixedAtBuild? Whereas both ArmVirtQemuKernel and ArmVirtXen define them as patchable. / Leif > --- > ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf > b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf > index 97b2a4b6e495..e59aef611a3c 100644 > --- a/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf > +++ b/ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf > @@ -41,9 +41,6 @@ [Sources.AArch64] > AArch64/ArmPlatformHelper.S > > [FixedPcd] > - gArmTokenSpaceGuid.PcdSystemMemoryBase > - gArmTokenSpaceGuid.PcdSystemMemorySize > - > gArmTokenSpaceGuid.PcdArmPrimaryCoreMask > gArmTokenSpaceGuid.PcdArmPrimaryCore > > -- > 2.11.0 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel