Yes. I mean to update comments in tools_def.template. Edk2 BaseTools doesn't include the party tools. And, without vswhere.exe, we don't know whether VS2017 is installed or not. For now, we only mention it in comments.
Thanks Liming > -----Original Message----- > From: Pete Batard [mailto:p...@akeo.ie] > Sent: Tuesday, November 21, 2017 2:41 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming....@intel.com> > Subject: Re: [PATCH v2 2/4] BaseTools: Add VS2017 tool chain in BaseTools > tools_def.template > > Hi Liming, > > On 2017.11.20 08:46, Gao, Liming wrote: > > Here, I suggest to mention VS version 15.2 or above, because vswhere.exe > > depends on this version. > > After later, you may also update this version to 15.4 for ARM and > > AARCH64 support. > > I assume you mean replacing the "Microsoft Visual Studio 2017 > Professional or Community Edition" from the comment with something like > "Microsoft Visual Studio 2017 version 15.2 or later", right? > > If so, I will do that and submit a v3. > > Do you think the possibility of adding vswhere.exe to > BaseTools\Bin\Win32 is also worth exploring? For one thing this would > solve the issue of locating 15.2 VS 2017 (as well as nonstandard > installations that may have removed the installer directory), and the > executable is both Open Source (MIT) and redistributable. > > The other possibility of course is to let pre 15.2 VS2017 fail the > detection process, and expect users to get a hint that they need an > updated version from the comments in tools_def... > > Regards, > > /Pete _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
