Hi Jiaxin, Please find my below comments/suggestions.
1. Yes, Current DHCP4/6 Start() implementation doesn't check for Media Status. It will be better to implement it in order to sync with UEFI spec. 2. DHCP process may be initiated by HTTP/PXE/ISCSI or Assigning IP (SetData) from Shell or using BIOS setup page. HTTP,PXE and ISCSI is already Checking Media Presence before DHCP Start, So it will have NO effect if we do implementation in DHCP4/6 Start(). 3. Current implementation of EFI_IP4_CONFIG2_SET_DATA, also NOT handling checking Media Status. a. UEFI Spec NOT defines EFI_NO_MEDIA status code for EFI_IP4_CONFIG2_SET_DATA, I'm NOT sure what's reason behind it or might be missing. b. UEFI Spec defines EFI_DEVICE_ERROR status code for EFI_IP4_CONFIG2_SET_DATA, If we can use the same status for Media presence then no issues. c. When there is No Media connected and if we try to assign IP over DHCP(SetData), I guess there is no need to proceed further in EfiIp4Config2SetData and we can return with EFI_DEVICE_ERROR. Based on above points(1 & 3.c ), I've updated the suggested changes and attached the same (CheckMediaStatus_V2.rar) Could you please review and provide your comments. Please correct if anything wrong. Thank You, Karunakar From: Wu, Jiaxin [mailto:jiaxin...@intel.com] Sent: Wednesday, November 29, 2017 11:57 AM To: Karunakar P; Fu, Siyuan; Ye, Ting Subject: RE: DHCP Process Starts Even there is NO Media Connected Hi Karunakar, After talk with Siyuan, we agree it's reasonable to check the Media status before starting DHCP process, but we'd better check it in DHCP layer since the UEFI spec defines EFI_NO_MEDIA status code for DHCP4/6.Start(), but our current implementation doesn't check it. What do you think? Thanks, Jiaxin From: Karunakar P [mailto:karunak...@amiindia.co.in] Sent: Tuesday, November 28, 2017 11:18 PM To: Wu, Jiaxin <jiaxin...@intel.com<mailto:jiaxin...@intel.com>>; Fu, Siyuan <siyuan...@intel.com<mailto:siyuan...@intel.com>>; Ye, Ting <ting...@intel.com<mailto:ting...@intel.com>> Subject: RE: DHCP Process Starts Even there is NO Media Connected Could you please review the attachment changes for this support. Thanks, Karunakar From: Karunakar P Sent: Monday, November 27, 2017 12:53 PM To: 'Wu, Jiaxin'; 'Fu, Siyuan'; 'Ye, Ting' Subject: RE: DHCP Process Starts Even there is NO Media Connected Could you please provide your comments... Thank You, Karunakar From: Karunakar P Sent: Thursday, November 23, 2017 2:05 PM To: 'Wu, Jiaxin'; Fu, Siyuan; Ye, Ting Subject: DHCP Process Starts Even there is NO Media Connected Hello All, When we try to Assign IP to SUT using ifconfig command from Shell or IPv4 Network Configuration BIOS setup page DHCP process start even there is no LAN cable connected to specific port. Can we add a Media presence condition check before starting DHCP service? Could you please correct if anything is wrong. Thanks, Karunakar _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
