Laszlo, Thank you very much for that! I will try to become a talkaholic when writing commit messages next time.
> -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, November 30, 2017 9:16 PM > To: Laszlo Ersek <ler...@redhat.com> > Cc: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v4 2/3] ArmVirtPkg: Fix build failure due to Tftp > library removal > > On 30 November 2017 at 12:22, Laszlo Ersek <ler...@redhat.com> wrote: > > On 11/29/17 14:53, Laszlo Ersek wrote: > >> Ray, > >> > >> On 11/29/17 11:14, Ruiyu Ni wrote: > >>> The TFTP command was converted from a NULL class library instance to > >>> a dynamic shell command in commit 0961002352e9. > >>> > >>> Contributed-under: TianoCore Contribution Agreement 1.1 > >>> Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > >>> Reviewed-by: Laszlo Ersek <ler...@redhat.com> > >>> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > >>> Cc: Julien Grall <julien.gr...@linaro.org> > >>> --- > >>> ArmVirtPkg/ArmVirt.dsc.inc | 11 +++++++---- > >>> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 ++- > >>> ArmVirtPkg/ArmVirtXen.fdf | 3 ++- > >>> 3 files changed, 11 insertions(+), 6 deletions(-) > >> > >> Can you please incorporate points (2) and (3) as well, from my v3 review? > >> > >> https://lists.01.org/pipermail/edk2-devel/2017-November/018191.html > > > > I fixed up the commit message as described above. > > > > I also test-built the ArmVirtQemu, ArmVirtQemuKernel and ArmVirtXen > > platforms, with the patch applied, for ARM and AARCH64. > > > > [ler...@redhat.com: extend commit message] > > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > > Build-tested-by: Laszlo Ersek <ler...@redhat.com> > > > > Commit 59fcf0706bf4. > > > > Thanks for taking care of this. The build had been broken long enough _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
