2017-12-04 14:52 GMT+01:00 Leif Lindholm <leif.lindh...@linaro.org>: > On Fri, Dec 01, 2017 at 04:35:06PM +0100, Marcin Wojtas wrote: >> fupdate command's usage information referred to a deprecated >> '-f' flag in 'examples' section. It was a residue from the >> initial version of the application, removed during review >> before merging to upstream branch. Correct the help information. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marcin Wojtas <m...@semihalf.com> > > I boggled slightly at how the file with deleted content is larger than > the original, so went to have a look, and what I see is: > > --- pre.txt 2017-12-04 13:43:32.985446108 +0000 > +++ post.txt 2017-12-04 13:44:30.433120594 +0000 > @@ -50,10 +50,10 @@ > ".SH EXAMPLES\r\n" > " \r\n" > "EXAMPLES:\r\n" > -"Update firmware from file fs2:flash-image.bin\r\n" > -" fupdate -f fs2:flash-image.bin\r\n" > +"Update firmware in SPI flash from file fs2:flash-image.bin\r\n" > +" fupdate fs2:flash-image.bin\r\n" > ".SH RETURNVALUES\r\n" > " \r\n" > "RETURN VALUES:\r\n" > " SHELL_SUCCESS The action was completed as requested.\r\n" > -" SHELL_ABORTED Error while processing command\r\n" > +" SHELL_ABORTED Error while processing command\r\n" > > > Now, I don't mind random format cleanup as much in .uni files as > elsewhere, since we don't get sane diffs anyway. But that also makes > detailed and accurate commit messages much more important. > > So please, add something about the rewording and the whitespace fixes. >
Sure, will do. Thanks, Marcin _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
