Hi Ard, On 30/11/17 20:31, Ard Biesheuvel wrote: > ArmVirtXen is the only remaining consumer of ArmPlatformPkg's > PlatformIntelBdsLib implementation, which is tightly coupled to the > deprecated Intel BDS. So move ArmVirtXen to the generic BDS as well, > allowing us to get rid of PlatformIntelBdsLib entirely.
It was in my list of UEFI part I wanted to look next :). I tested it and hit the following assert: ASSERT [BdsDxe] /home/julieng/works/edk2/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c(502): 0 == 4 Looking at the ArmVirtQemu.dsc, I made the below modification. When I tried the version protected by TTY_ENABLE, the ASSERT was still present. diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc index ae43d59901..bc76a780be 100644 --- a/ArmVirtPkg/ArmVirtXen.dsc +++ b/ArmVirtPkg/ArmVirtXen.dsc @@ -81,6 +81,10 @@ # Size of the region used by UEFI in permanent memory (Reserved 64MB) gArmPlatformTokenSpaceGuid.PcdSystemMemoryUefiRegionSize|0x04000000 + ## Default Terminal Type^M + ## 0-PCANSI, 1-VT100, 2-VT00+, 3-UTF8, 4-TTYTERM^M + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|4^M +^M # # ARM Virtual Architectural Timer # My knowledge in UEFI is still limited, so I would appreciate any feedbacks here. Cheers, -- Julien Grall _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
