Sure. Thanks for the feedback.
> -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, December 04, 2017 9:59 PM > To: Wang, Jian J <jian.j.w...@intel.com> > Cc: edk2-devel@lists.01.org; Leif Lindholm <leif.lindh...@linaro.org>; Yao, > Jiewen <jiewen....@intel.com> > Subject: Re: [PATCH v3 07/11] ArmPkg/ArmExceptionLib: Add implementation of > new API > > On 1 December 2017 at 02:37, Jian J Wang <jian.j.w...@intel.com> wrote: > >> v3: > >> Newly added > > > > This patch add implementation of following new API introduced into > > CpuExceptionHandlerLib. Since this lib hasn't support Stack Guard > > and stack switch, the new method just calls original > > InitializeCpuExceptionHandlers. > > > > EFI_STATUS > > EFIAPI > > InitializeCpuExceptionHandlersEx ( > > IN EFI_VECTOR_HANDOFF_INFO *VectorInfo OPTIONAL, > > IN CPU_EXCEPTION_INIT_DATA_EX *InitDataEx OPTIONAL > > ); > > > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > > Cc: Jiewen Yao <jiewen....@intel.com> > > Suggested-by: Ayellet Wolman <ayellet.wol...@intel.com> > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Jian J Wang <jian.j.w...@intel.com> > > --- > > ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c | 33 > ++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c > b/ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c > > index e8ea1f159d..9fb4a05845 100644 > > --- a/ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c > > +++ b/ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.c > > @@ -320,3 +320,36 @@ CommonCExceptionHandler( > > > > DefaultExceptionHandler(ExceptionType, SystemContext); > > } > > + > > +/** > > + Initializes all CPU exceptions entries with optional extra > > initializations. > > + > > + By default, this method should include all functionalities implemented by > > + InitializeCpuExceptionHandlers(), plus extra initialization works, if > > any. > > + This is could be done by calling InitializeCpuExceptionHandlers() > > directly > > + in this method besides the extra works. > > + > > + InitDataEx is optional and its use and content are processor arch > > dependent. > > + The typical usage of it is to convey resources which have to be reserved > > + elsewhere and are necessary for the extra initializations of exception. > > + > > + @param[in] VectorInfo Pointer to reserved vector list. > > + @param[in] InitDataEx Pointer to data optional for extra > > initializations > > + of exception. > > + > > + @retval EFI_SUCCESS The exceptions have been successfully > > + initialized. > > + @retval EFI_INVALID_PARAMETER VectorInfo or InitDataEx contains > invalid > > + content. > > + > > +**/ > > +EFI_STATUS > > +EFIAPI > > +InitializeCpuExceptionHandlersEx ( > > + IN EFI_VECTOR_HANDOFF_INFO *VectorInfo OPTIONAL, > > + IN CPU_EXCEPTION_INIT_DATA_EX *InitDataEx OPTIONAL > > + ) > > +{ > > + return InitializeCpuExceptionHandlers (VectorInfo); > > +} > > + > > I would appreciate it if you could clean up the grammar in the comment block. > > Other than that, > > Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
