Looks good to me. Reviewed-by: Jian J Wang <jian.j.w...@intel.com>
> -----Original Message----- > From: Zeng, Star > Sent: Friday, December 08, 2017 11:03 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Wang, Jian J <jian.j.w...@intel.com> > Subject: [PATCH] MdeModulePkg DxeIpl: Move > ClearFirst4KPage/IsNullDetectionEnabled definition > > Move ClearFirst4KPage/IsNullDetectionEnabled definition from DxeIpl.h to > VirtualMemory.h as they are implemented in VirtualMemory.c and only used > in IA32/X64 ARCH. > > Cc: Jian J Wang <jian.j.w...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng <star.z...@intel.com> > --- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.h | 27 > +----------------------- > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h | 26 > ++++++++++++++++++++++- > 2 files changed, 26 insertions(+), 27 deletions(-) > > diff --git a/MdeModulePkg/Core/DxeIplPeim/DxeIpl.h > b/MdeModulePkg/Core/DxeIplPeim/DxeIpl.h > index f3aabdb7e0f0..6f8e13d21335 100644 > --- a/MdeModulePkg/Core/DxeIplPeim/DxeIpl.h > +++ b/MdeModulePkg/Core/DxeIplPeim/DxeIpl.h > @@ -2,7 +2,7 @@ > Master header file for DxeIpl PEIM. All source files in this module should > include this file for common definitions. > > -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > which accompanies this distribution. The full text of the license may be > found > at > @@ -240,29 +240,4 @@ Decompress ( > OUT UINTN *OutputSize > ); > > -/** > - Clear legacy memory located at the first 4K-page. > - > - This function traverses the whole HOB list to check if memory from 0 to > 4095 > - exists and has not been allocated, and then clear it if so. > - > - @param HobStart The start of HobList passed to DxeCore. > - > -**/ > -VOID > -ClearFirst4KPage ( > - IN VOID *HobStart > - ); > - > -/** > - Return configure status of NULL pointer detection feature. > - > - @return TRUE NULL pointer detection feature is enabled > - @return FALSE NULL pointer detection feature is disabled > -**/ > -BOOLEAN > -IsNullDetectionEnabled ( > - VOID > - ); > - > #endif > diff --git a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h > b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h > index 7c9bb49e3e2c..26a2100f0b80 100644 > --- a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h > +++ b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h > @@ -7,7 +7,7 @@ > 3) IA-32 Intel(R) Architecture Software Developer's Manual Volume > 3:System > Programmer's Guide, Intel > 4) AMD64 Architecture Programmer's Manual Volume 2: System > Programming > > -Copyright (c) 2006 - 2015, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR> > Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR> > > This program and the accompanying materials > @@ -227,5 +227,29 @@ AsmGetVectorTemplatInfo ( > OUT VOID **TemplateBase > ); > > +/** > + Clear legacy memory located at the first 4K-page. > + > + This function traverses the whole HOB list to check if memory from 0 to > 4095 > + exists and has not been allocated, and then clear it if so. > + > + @param HobStart The start of HobList passed to DxeCore. > + > +**/ > +VOID > +ClearFirst4KPage ( > + IN VOID *HobStart > + ); > + > +/** > + Return configure status of NULL pointer detection feature. > + > + @return TRUE NULL pointer detection feature is enabled > + @return FALSE NULL pointer detection feature is disabled > +**/ > +BOOLEAN > +IsNullDetectionEnabled ( > + VOID > + ); > > #endif > -- > 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
