reviewed-by: jiewen....@intel.com
> -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star > Zeng > Sent: Wednesday, December 20, 2017 5:49 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Gao, Liming <liming....@intel.com>; > Zeng, Star <star.z...@intel.com> > Subject: [edk2] [PATCH] MdePkg Acpi60.h: Add missing PCCT subspace type 1 > and 2 definitions > > Same change is done for Acpi61.h. > > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Chasel Chiu <chasel.c...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng <star.z...@intel.com> > --- > MdePkg/Include/IndustryStandard/Acpi60.h | 48 > +++++++++++++++++++++++++++++++- > MdePkg/Include/IndustryStandard/Acpi61.h | 48 > +++++++++++++++++++++++++++++++- > 2 files changed, 94 insertions(+), 2 deletions(-) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h > b/MdePkg/Include/IndustryStandard/Acpi60.h > index 6183d8a9bd6c..29c16f48405d 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi60.h > +++ b/MdePkg/Include/IndustryStandard/Acpi60.h > @@ -2020,7 +2020,9 @@ typedef struct { > // > // PCCT Subspace type > // > -#define EFI_ACPI_6_0_PCCT_SUBSPACE_TYPE_GENERIC 0x00 > +#define EFI_ACPI_6_0_PCCT_SUBSPACE_TYPE_GENERIC > 0x00 > +#define > EFI_ACPI_6_0_PCCT_SUBSPACE_TYPE_1_HW_REDUCED_COMMUNICATIONS > 0x01 > +#define > EFI_ACPI_6_0_PCCT_SUBSPACE_TYPE_2_HW_REDUCED_COMMUNICATIONS > 0x02 > > /// > /// PCC Subspace Structure Header > @@ -2072,6 +2074,50 @@ typedef struct { > EFI_ACPI_6_0_PCCT_GENERIC_SHARED_MEMORY_REGION_STATUS > Status; > } EFI_ACPI_6_0_PCCT_GENERIC_SHARED_MEMORY_REGION_HEADER; > > +#define > EFI_ACPI_6_0_PCCT_SUBSPACE_DOORBELL_INTERRUPT_FLAGS_POLARITY > BIT0 > +#define > EFI_ACPI_6_0_PCCT_SUBSPACE_DOORBELL_INTERRUPT_FLAGS_MODE > BIT1 > + > +/// > +/// Type 1 HW-Reduced Communications Subspace Structure > +/// > +typedef struct { > + UINT8 Type; > + UINT8 Length; > + UINT32 DoorbellInterrupt; > + UINT8 DoorbellInterruptFlags; > + UINT8 Reserved; > + UINT64 BaseAddress; > + UINT64 AddressLength; > + EFI_ACPI_6_0_GENERIC_ADDRESS_STRUCTURE DoorbellRegister; > + UINT64 DoorbellPreserve; > + UINT64 DoorbellWrite; > + UINT32 NominalLatency; > + UINT32 > MaximumPeriodicAccessRate; > + UINT16 > MinimumRequestTurnaroundTime; > +} EFI_ACPI_6_0_PCCT_SUBSPACE_1_HW_REDUCED_COMMUNICATIONS; > + > +/// > +/// Type 2 HW-Reduced Communications Subspace Structure > +/// > +typedef struct { > + UINT8 Type; > + UINT8 Length; > + UINT32 DoorbellInterrupt; > + UINT8 DoorbellInterruptFlags; > + UINT8 Reserved; > + UINT64 BaseAddress; > + UINT64 AddressLength; > + EFI_ACPI_6_0_GENERIC_ADDRESS_STRUCTURE DoorbellRegister; > + UINT64 DoorbellPreserve; > + UINT64 DoorbellWrite; > + UINT32 NominalLatency; > + UINT32 > MaximumPeriodicAccessRate; > + UINT16 > MinimumRequestTurnaroundTime; > + EFI_ACPI_6_0_GENERIC_ADDRESS_STRUCTURE DoorbellAckRegister; > + UINT64 DoorbellAckPreserve; > + UINT64 DoorbellAckWrite; > +} EFI_ACPI_6_0_PCCT_SUBSPACE_2_HW_REDUCED_COMMUNICATIONS; > + > // > // Known table signatures > // > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h > b/MdePkg/Include/IndustryStandard/Acpi61.h > index 0fac9a80694d..4a370c27e012 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi61.h > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h > @@ -2052,7 +2052,9 @@ typedef struct { > // > // PCCT Subspace type > // > -#define EFI_ACPI_6_1_PCCT_SUBSPACE_TYPE_GENERIC 0x00 > +#define EFI_ACPI_6_1_PCCT_SUBSPACE_TYPE_GENERIC > 0x00 > +#define > EFI_ACPI_6_1_PCCT_SUBSPACE_TYPE_1_HW_REDUCED_COMMUNICATIONS > 0x01 > +#define > EFI_ACPI_6_1_PCCT_SUBSPACE_TYPE_2_HW_REDUCED_COMMUNICATIONS > 0x02 > > /// > /// PCC Subspace Structure Header > @@ -2104,6 +2106,50 @@ typedef struct { > EFI_ACPI_6_1_PCCT_GENERIC_SHARED_MEMORY_REGION_STATUS > Status; > } EFI_ACPI_6_1_PCCT_GENERIC_SHARED_MEMORY_REGION_HEADER; > > +#define > EFI_ACPI_6_1_PCCT_SUBSPACE_DOORBELL_INTERRUPT_FLAGS_POLARITY > BIT0 > +#define > EFI_ACPI_6_1_PCCT_SUBSPACE_DOORBELL_INTERRUPT_FLAGS_MODE > BIT1 > + > +/// > +/// Type 1 HW-Reduced Communications Subspace Structure > +/// > +typedef struct { > + UINT8 Type; > + UINT8 Length; > + UINT32 DoorbellInterrupt; > + UINT8 DoorbellInterruptFlags; > + UINT8 Reserved; > + UINT64 BaseAddress; > + UINT64 AddressLength; > + EFI_ACPI_6_1_GENERIC_ADDRESS_STRUCTURE DoorbellRegister; > + UINT64 DoorbellPreserve; > + UINT64 DoorbellWrite; > + UINT32 NominalLatency; > + UINT32 > MaximumPeriodicAccessRate; > + UINT16 > MinimumRequestTurnaroundTime; > +} EFI_ACPI_6_1_PCCT_SUBSPACE_1_HW_REDUCED_COMMUNICATIONS; > + > +/// > +/// Type 2 HW-Reduced Communications Subspace Structure > +/// > +typedef struct { > + UINT8 Type; > + UINT8 Length; > + UINT32 DoorbellInterrupt; > + UINT8 DoorbellInterruptFlags; > + UINT8 Reserved; > + UINT64 BaseAddress; > + UINT64 AddressLength; > + EFI_ACPI_6_1_GENERIC_ADDRESS_STRUCTURE DoorbellRegister; > + UINT64 DoorbellPreserve; > + UINT64 DoorbellWrite; > + UINT32 NominalLatency; > + UINT32 > MaximumPeriodicAccessRate; > + UINT16 > MinimumRequestTurnaroundTime; > + EFI_ACPI_6_1_GENERIC_ADDRESS_STRUCTURE DoorbellAckRegister; > + UINT64 DoorbellAckPreserve; > + UINT64 DoorbellAckWrite; > +} EFI_ACPI_6_1_PCCT_SUBSPACE_2_HW_REDUCED_COMMUNICATIONS; > + > // > // Known table signatures > // > -- > 2.7.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
