Good day, I noticed this patch lacks the definition of "EFI_FV_FILETYPE_MM_CORE" (0x0C). Furthermore, may I suggest changing the *_SMM_* definitions to be defined via the *_MM_* definitions?
Best regards, Marvin. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Supreeth Venkatesh > Sent: Tuesday, January 23, 2018 9:03 PM > To: edk2-devel@lists.01.org > Cc: michael.d.kin...@intel.com; liming....@intel.com > Subject: [edk2] [PATCH v1 1/1] MdePkg/Include: Add management mode FV > file type and depex. > > As per PI specification v1.6, > The following new file types are added: > EFI_FV_FILETYPE_MM_STANDALONE > EFI_FV_FILETYPE_MM_CORE_STANDALONE > > The following new section type is added: > EFI_SECTION_MM_DEPEX > > This patch adds the management mode FV file type and depex. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Achin Gupta <achin.gu...@arm.com> > Signed-off-by: Supreeth Venkatesh <supreeth.venkat...@arm.com> > Reviewed-by: Jiewen Yao <jiewen....@intel.com> > --- > MdePkg/Include/Pi/PiFirmwareFile.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/MdePkg/Include/Pi/PiFirmwareFile.h > b/MdePkg/Include/Pi/PiFirmwareFile.h > index b982c9eda3..6086d1bb2f 100644 > --- a/MdePkg/Include/Pi/PiFirmwareFile.h > +++ b/MdePkg/Include/Pi/PiFirmwareFile.h > @@ -72,9 +72,12 @@ typedef UINT8 EFI_FFS_FILE_STATE; #define > EFI_FV_FILETYPE_COMBINED_PEIM_DRIVER 0x08 > #define EFI_FV_FILETYPE_APPLICATION 0x09 > #define EFI_FV_FILETYPE_SMM 0x0A > +#define EFI_FV_FILETYPE_MM 0x0A > #define EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE 0x0B > #define EFI_FV_FILETYPE_COMBINED_SMM_DXE 0x0C > +#define EFI_FV_FILETYPE_COMBINED_MM_DXE 0x0C > #define EFI_FV_FILETYPE_SMM_CORE 0x0D > +#define EFI_FV_FILETYPE_MM_STANDALONE 0x0E > #define EFI_FV_FILETYPE_OEM_MIN 0xc0 > #define EFI_FV_FILETYPE_OEM_MAX 0xdf > #define EFI_FV_FILETYPE_DEBUG_MIN 0xe0 > @@ -218,6 +221,7 @@ typedef UINT8 EFI_SECTION_TYPE; > #define EFI_SECTION_RAW 0x19 > #define EFI_SECTION_PEI_DEPEX 0x1B > #define EFI_SECTION_SMM_DEPEX 0x1C > +#define EFI_SECTION_MM_DEPEX 0x1C > > /// > /// Common section header. > -- > 2.14.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
