On 26 January 2018 at 17:34, Leif Lindholm <leif.lindh...@linaro.org> wrote:
> On Fri, Jan 26, 2018 at 05:31:25PM +0000, Ard Biesheuvel wrote:
>> On 26 January 2018 at 17:30, Leif Lindholm <leif.lindh...@linaro.org> wrote:
>> > Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of
>> > the unfortunate ARM-specific variant of PcdFirmwareVendor.
>> >
>> > However, BeagleBoard was still using it, so the change broke the build.
>> > Fix this by moving BeagleBoard to use the MdeModulePkg one instead.
>> >
>> > Contributed-under: TianoCore Contribution Agreement 1.1
>> > Signed-off-by: Leif Lindholm <leif.lindh...@linaro.org>
>> > ---
>> > BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc
>> > b/BeagleBoardPkg/BeagleBoardPkg.dsc
>> > index 5d87ee3891..cef2e095d4 100644
>> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
>> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
>> > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common]
>> > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
>> >
>> > [PcdsFixedAtBuild.common]
>> > - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
>> > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
>>
>> That should probably be L"Beagle Board"
>
> Good point.
> Happy with me folding that in?
>
Sure
Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
