On 02/08/18 00:48, Kinney, Michael D wrote: > Laszlo, > > The BmpSupportLib content was from contributions from > a capsule related branch. However, the BmpSupportLib > can be used for UX capsules as well as other places that > conversions between BMP and GOP BLT buffers are needed, > so it is a more generic feature. The SafeIntLib was also > based on content from the same capsule related branch but > also has uses other than capsules. > > Yes. I need to add Signed-off-by for Sean.
OK, with the S-o-b updated, for patches #5 and #10: Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thank you, Laszlo > Thanks for the "xfuncname" tip. I will add that to my > notes for sending patch emails so it is always enabled. > > Mike > >> -----Original Message----- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, February 7, 2018 3:17 PM >> To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2- >> de...@lists.01.org >> Cc: Sean Brogan <sean.bro...@microsoft.com>; Yao, Jiewen >> <jiewen....@intel.com>; Justen, Jordan L >> <jordan.l.jus...@intel.com>; Ard Biesheuvel >> <ard.biesheu...@linaro.org> >> Subject: Re: [Patch 05/10] OvmfPkg: Add SafeIntLib and >> BmpSupportLib to DSC files >> >> Hi Mike, >> >> On 02/07/18 23:58, Kinney, Michael D wrote: >>> From: Michael D Kinney <michael.d.kin...@intel.com> >>> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=800 >>> >>> Based on content from the following branch/commits: >>> >> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsule >> Support >>> >> https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417 >> d7d5a7d356c15a14c2e60302b2d >>> >> https://github.com/Microsoft/MS_UEFI/commit/ca516b1a61315 >> c2d823f453e12d2135098f53d61 >>> >> https://github.com/Microsoft/MS_UEFI/commit/2b9f111f2e74a >> 4c2ef4c4e32379e111f016dbd9b >> >> These commits look capsule-related, but the paragraph >> below speaks about >> BootGraphicsResourceTableDxe and image format conversion. >> Should the >> references be updated? >> >> Also, if part of the code is from Sean, do we need an S- >> o-b from him, >> above yours? >> >> The DSC file changes look fine; I'm ready to R-b once the >> above is >> clarified. >> >> (For the future, please consider the "xfuncname" setting >> from >> <https://github.com/tianocore/tianocore.github.io/wiki/La >> szlo's-unkempt-git-guide-for-edk2-contributors-and- >> maintainers#contrib-05>, >> together with >> <https://github.com/tianocore/tianocore.github.io/wiki/La >> szlo's-unkempt-git-guide-for-edk2-contributors-and- >> maintainers#contrib-09>. >> >> Those settings help with the review of DSC and similar >> files -- the @@ >> hunk headers in the patch will state the [LibraryClasses] >> file section, >> for example.) >> >> Thanks, >> Laszlo >> >>> The BootGraphicsResourceTableDxe module uses the >> BmpSupportLib >>> and SafeIntLib to convert a GOP BLT buffer to a BMP >> graphics image. >>> Add library mappings for these new library classes. >>> >>> Cc: Sean Brogan <sean.bro...@microsoft.com> >>> Cc: Jiewen Yao <jiewen....@intel.com> >>> Cc: Jordan Justen <jordan.l.jus...@intel.com> >>> Cc: Laszlo Ersek <ler...@redhat.com> >>> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Michael D Kinney >> <michael.d.kin...@intel.com> >>> --- >>> OvmfPkg/OvmfPkgIa32.dsc | 2 ++ >>> OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ >>> OvmfPkg/OvmfPkgX64.dsc | 2 ++ >>> 3 files changed, 6 insertions(+) >>> >>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc >> b/OvmfPkg/OvmfPkgIa32.dsc >>> index d762955c5d..e10f898607 100644 >>> --- a/OvmfPkg/OvmfPkgIa32.dsc >>> +++ b/OvmfPkg/OvmfPkgIa32.dsc >>> @@ -104,6 +104,8 @@ >>> >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >>> >> BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemo >> ryLibRepStr.inf >>> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf >>> + >> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i >> nf >>> + >> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base >> BmpSupportLib.inf >>> >> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/ >> BaseSynchronizationLib.inf >>> CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf >>> >> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base >> PerformanceLibNull.inf >>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc >> b/OvmfPkg/OvmfPkgIa32X64.dsc >>> index 6bcbe70d64..a31c7919ad 100644 >>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc >>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc >>> @@ -109,6 +109,8 @@ >>> >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >>> >> BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemo >> ryLibRepStr.inf >>> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf >>> + >> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i >> nf >>> + >> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base >> BmpSupportLib.inf >>> >> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/ >> BaseSynchronizationLib.inf >>> CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf >>> >> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base >> PerformanceLibNull.inf >>> diff --git a/OvmfPkg/OvmfPkgX64.dsc >> b/OvmfPkg/OvmfPkgX64.dsc >>> index 70fcdcba11..bc433a9724 100644 >>> --- a/OvmfPkg/OvmfPkgX64.dsc >>> +++ b/OvmfPkg/OvmfPkgX64.dsc >>> @@ -109,6 +109,8 @@ >>> >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >>> >> BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemo >> ryLibRepStr.inf >>> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf >>> + >> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i >> nf >>> + >> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base >> BmpSupportLib.inf >>> >> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/ >> BaseSynchronizationLib.inf >>> CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf >>> >> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base >> PerformanceLibNull.inf >>> > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
