On 22 February 2018 at 13:44, Leif Lindholm <leif.lindh...@linaro.org> wrote: > On Thu, Feb 22, 2018 at 01:21:37PM +0000, Ard Biesheuvel wrote: >> On 22 February 2018 at 13:15, Leif Lindholm <leif.lindh...@linaro.org> wrote: >> > On Tue, Feb 20, 2018 at 05:49:39PM +0000, Ard Biesheuvel wrote: >> >> Introduce the mezzanine protocol and the 96boards package defining >> >> the PCDs and GUIDs that may be used by implementations of the >> >> protocol. >> > >> > This looks really good. Comments below are all style related. >> > >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> >> >> --- >> >> Platform/NinetySixBoards/Include/Protocol/Mezzanine.h | 71 >> >> ++++++++++++++++++++ >> >> Platform/NinetySixBoards/NinetySixBoards.dec | 67 >> >> ++++++++++++++++++ >> > >> > Why NinetySixBoards? Is 96Boards ENOTENOUGHCAMEL? >> > >> >> That is what I started out with, but having CPP macros and lots of VFR >> identifiers and other bits and pieces using leading digits was making >> me nervous about whether it is supported in all configurations, so I >> bit the bullet and renamed everything. > > I understand the paranoia, but we do have > PcAtChipsetPkg/8259InterruptControllerDxe > and > PcAtChipsetPkg/8254TimerDxe > so I would expect this to actually be reasonably well supported. > > We may not have to worry about 3com and 3ware anymore, but if someone > wants to write drivers for ancient cards, I'd still prefer to be able > to give them predictable paths. >
Fair enough, I'll change it back. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
