On 3/1/2018 6:20 PM, Laszlo Ersek wrote:
On 03/01/18 07:57, Heyi Guo wrote:
Use ZeroMem to initialize all fields in temporary
PCI_ROOT_BRIDGE_APERTURE variables to zero. This is not mandatory but
is helpful for future extension: when we add new fields to
PCI_ROOT_BRIDGE_APERTURE and the default value of these fields can
safely be zero, this code will not suffer from an additional
change.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Heyi Guo <heyi....@linaro.org>

Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Anthony Perard <anthony.per...@citrix.com>
Cc: Julien Grall <julien.gr...@linaro.org>
Cc: Ruiyu Ni <ruiyu...@intel.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
---
  OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 ++++
  OvmfPkg/Library/PciHostBridgeLib/XenSupport.c       | 5 +++++
  2 files changed, 9 insertions(+)

I also suggest a different subject line:

OvmfPkg/PciHostBridgeLib: clear PCI_ROOT_BRIDGE_APERTURE vars for (re)init

(74 chars)

I sometimes tries very hard to make the subject line be <= 70 chars.
74 is acceptable?


Thanks
Laszlo



--
Thanks,
Ray
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to