I have handled the mistake at https://github.com/lzeng14/edk2/tree/DebugCommUsb3AfterIOMMUV2_WIP.
If you need, I can resend V2 patch. :) Thanks, Star -----Original Message----- From: Zeng, Star Sent: Monday, March 12, 2018 10:28 AM To: Wu, Hao A <hao.a...@intel.com>; edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen....@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com> Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU Hao, Good catch. :) It is a mistake when splitting patch. Thanks, Star -----Original Message----- From: Wu, Hao A Sent: Monday, March 12, 2018 10:10 AM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Cc: Yao, Jiewen <jiewen....@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> Subject: RE: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements after supporting IOMMU One minor comment: For patch 3, within changes in function Usb3PciIoNotify(): Usb3NamedEventListen ( &gEfiDxeSmmReadyToLockProtocolGuid, TPL_NOTIFY, Usb3DxeSmmReadyToLockNotify, &SmmReadyToLockEvent <--- Does this change related with patch 2? ); Otherwise, for me, patch 2 is storing the event for DxeSmmReadyToLockProtocol in an event which will be closed right after. Best Regards, Hao Wu > -----Original Message----- > From: Zeng, Star > Sent: Sunday, March 11, 2018 11:16 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Yao, Jiewen; Ni, Ruiyu; Wu, Hao A > Subject: [PATCH 0/3] SouceLevelDebugPkg DebugCommUsb3: Enhancements > after supporting IOMMU > > Please get detailed information in the separated patches. > > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Ruiyu Ni <ruiyu...@intel.com> > Cc: Hao Wu <hao.a...@intel.com> > > Star Zeng (3): > SourceLevelDebugPkg DebugCommUsb3: Refine some formats > SourceLevelDebugPkg DebugCommUsb3: Realloc granted DXE DMA buffer > SourceLevelDebugPkg DebugCommUsb3: Use the Handle from DebugAgentLib > > .../DebugCommunicationLibUsb3Common.c | 96 +++++- > .../DebugCommunicationLibUsb3Dxe.c | 365 > ++++++++++++--------- > .../DebugCommunicationLibUsb3Dxe.inf | 11 +- > .../DebugCommunicationLibUsb3Internal.h | 60 +--- > .../DebugCommunicationLibUsb3Pei.c | 50 ++- > .../DebugCommunicationLibUsb3Pei.inf | 4 +- > 6 files changed, 332 insertions(+), 254 deletions(-) > > -- > 2.13.3.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel