On 02/02/18 15:39, Laszlo Ersek wrote: > All edk2 toolchains use NASM for compiling X86 assembly source code. We > plan to remove X86 *.S and *.asm files globally, in order to reduce > maintenance and confusion: > > 4A89E2EF3DFEDB4C8BFDE51014F606A14E1B9F76@SHSMSX104.ccr.corp.intel.com">http://mid.mail-archive.com/4A89E2EF3DFEDB4C8BFDE51014F606A14E1B9F76@SHSMSX104.ccr.corp.intel.com > > Let's start with UefiCpuPkg/PiSmmCpuDxeSmm: remove the *.S and *.asm > dialects (both Ia32 and X64) of the SmmInit, SmiEntry, SmiException and > MpFuncs sources. > > Cc: Eric Dong <eric.d...@intel.com> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Ruiyu Ni <ruiyu...@intel.com> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=866 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 20 - > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.S | 165 ----- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.asm | 168 ----- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.S | 215 ------ > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.asm | 223 ------ > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.S | 696 ------------------- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.asm | 713 -------------------- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmInit.S | 84 --- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmInit.asm | 94 --- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.S | 204 ------ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.asm | 206 ------ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.S | 243 ------- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.asm | 242 ------- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.S | 365 ---------- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.asm | 383 ----------- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.S | 141 ---- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.asm | 132 ---- > 17 files changed, 4294 deletions(-)
This patch (and possibly other patches in the set -- I can't tell) has been Reviewed-by: Andrew Fish <af...@apple.com> off-list; many thanks for that. The idea that this driver keep only NASM assembly files does not cause problems like those described in: https://lists.01.org/pipermail/edk2-devel/2018-March/022690.html https://bugzilla.tianocore.org/show_bug.cgi?id=881 Can we please continue the review? The last message in the thread was a8dca174-30b7-725d-7683-89020ce22b7d@redhat.com">http://mid.mail-archive.com/a8dca174-30b7-725d-7683-89020ce22b7d@redhat.com Thanks, Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
