remove unused code/variables/file move re.compile to eliminate recompiling same expression replace string constants in code with predefined constants (including sets, preferred for "in" testing, and lists of string constants) (include making new constants, sets, and lists) switch dict to defaultdict to eliminate initialization code dont compare using "in [None,'']" as python does that by default use a shared Component to Module map
Jaben Carsey (27): BaseTools: Misc - refactor RegEx to minimize multiple compiling BaseTools: GenPatchPcdTable - refactor RegEx to minimize multiple compiling BaseTools: Share RegEx between files BaseTools: Workspace - refactor RegEx to minimize multiple compiling BaseTools: Autogen - replace string constants with those from DataType BaseTools: simplify if call BaseTools: Workspace - refactor GetStructurePcdInfo BaseTools: AutoGen - remove dictionary populated, but never accessed BaseTools: AutoGen - remove unused variables. BaseTools: Remove extra .keys() BaseTools: Workspace/MetaFileParser - refactor dicts BaseTools: remove dict from DscBuildData BaseTools: replace string constants used for module types BaseTools: Define and use a set for common list BaseTools: Share a dictionary instead of keeping multiples BaseTools: Replace EDK Component strings with predefined constant BaseTools: DataType - cleanup list constants BaseTools: Replace PCD type strings with predefined constant BaseTools: Replace Binary File type strings with predefined constant BaseTools: remove duplicate variable BaseTools: replace string with predefined constant BaseTools: remove redundant if comparison BaseTools: AutoGen - use dafultdict instead of dict BaseTools: GenFds - simplify testing for Hex number BaseTools: AutoGen - use defaultdict to auto initialize BaseTools: remove unused MigrationUtilities.py BaseTools: CommonClass - remove unused classes BaseTools/Source/Python/AutoGen/AutoGen.py | 153 +++--- BaseTools/Source/Python/AutoGen/BuildEngine.py | 10 +- BaseTools/Source/Python/AutoGen/GenC.py | 170 +++--- BaseTools/Source/Python/AutoGen/GenDepex.py | 33 +- BaseTools/Source/Python/AutoGen/GenMake.py | 2 - BaseTools/Source/Python/AutoGen/GenPcdDb.py | 12 +- BaseTools/Source/Python/AutoGen/GenVar.py | 6 +- BaseTools/Source/Python/Common/DataType.py | 54 +- BaseTools/Source/Python/Common/Expression.py | 4 +- BaseTools/Source/Python/Common/GlobalData.py | 1 + BaseTools/Source/Python/Common/MigrationUtilities.py | 568 -------------------- BaseTools/Source/Python/Common/Misc.py | 26 +- BaseTools/Source/Python/CommonDataClass/CommonClass.py | 397 +------------- BaseTools/Source/Python/Ecc/Check.py | 6 +- BaseTools/Source/Python/Ecc/Configuration.py | 2 +- BaseTools/Source/Python/Ecc/c.py | 2 +- BaseTools/Source/Python/GenFds/CompressSection.py | 3 +- BaseTools/Source/Python/GenFds/DataSection.py | 8 +- BaseTools/Source/Python/GenFds/DepexSection.py | 17 +- BaseTools/Source/Python/GenFds/EfiSection.py | 25 +- BaseTools/Source/Python/GenFds/Fd.py | 3 +- BaseTools/Source/Python/GenFds/FdfParser.py | 121 ++--- BaseTools/Source/Python/GenFds/Ffs.py | 51 +- BaseTools/Source/Python/GenFds/FfsInfStatement.py | 56 +- BaseTools/Source/Python/GenFds/Fv.py | 6 +- BaseTools/Source/Python/GenFds/FvImageSection.py | 5 +- BaseTools/Source/Python/GenFds/GenFds.py | 10 +- BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 40 +- BaseTools/Source/Python/GenFds/GuidSection.py | 5 +- BaseTools/Source/Python/GenFds/OptRomInfStatement.py | 3 +- BaseTools/Source/Python/GenFds/Region.py | 5 +- BaseTools/Source/Python/GenFds/Section.py | 46 +- BaseTools/Source/Python/GenFds/UiSection.py | 3 +- BaseTools/Source/Python/GenFds/VerSection.py | 3 +- BaseTools/Source/Python/GenPatchPcdTable/GenPatchPcdTable.py | 23 +- BaseTools/Source/Python/Makefile | 1 - BaseTools/Source/Python/Trim/Trim.py | 2 +- BaseTools/Source/Python/Workspace/DecBuildData.py | 22 +- BaseTools/Source/Python/Workspace/DscBuildData.py | 51 +- BaseTools/Source/Python/Workspace/InfBuildData.py | 74 +-- BaseTools/Source/Python/Workspace/MetaFileParser.py | 27 +- BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 2 +- BaseTools/Source/Python/build/BuildReport.py | 99 ++-- BaseTools/Source/Python/build/build.py | 16 +- 44 files changed, 583 insertions(+), 1590 deletions(-) delete mode 100644 BaseTools/Source/Python/Common/MigrationUtilities.py -- 2.16.2.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel