Can you also update the comment to match the code please. I think that the comment is wrong and your code is correct, but now they are opposite. The comment says skip (return in context) for no binary files, but the new code will skip for modules with binary files...
-Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhu, Yonghong > Sent: Wednesday, April 25, 2018 11:51 PM > To: Zhu, Yonghong <yonghong....@intel.com>; edk2-devel@lists.01.org > Cc: Feng, YunhuaX <yunhuax.f...@intel.com>; Gao, Liming > <liming....@intel.com> > Subject: Re: [edk2] [Patch] BaseTools: Fix one invalid change in 6be94743 > > Reviewed-by: Yonghong Zhu <yonghong....@intel.com> > > Best Regards, > Zhu Yonghong > > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Wednesday, April 25, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Feng, YunhuaX <yunhuax.f...@intel.com>; Gao, Liming > <liming....@intel.com> > Subject: [edk2] [Patch] BaseTools: Fix one invalid change in 6be94743 > > From: Yunhua Feng <yunhuax.f...@intel.com> > > Roll back one change in 6be94743, it was updated incorrect. > > Cc: Liming Gao <liming....@intel.com> > Cc: Yonghong Zhu <yonghong....@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yunhua Feng <yunhuax.f...@intel.com> > --- > BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py > b/BaseTools/Source/Python/AutoGen/AutoGen.py > index 56b5d39..ba83d5a 100644 > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > @@ -3914,11 +3914,11 @@ class ModuleAutoGen(AutoGen): > # Skip the following code for modules with no source files > if not self.SourceFileList: > return > > # Skip the following code for modules without any binary files > - if not self.BinaryFileList: > + if self.BinaryFileList: > return > > ### TODO: How to handles mixed source and binary modules > > # Find all DynamicEx and PatchableInModule PCDs used by this module > and dependent libraries > -- > 2.6.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
