Hi Gerd, On 06/08/18 13:39, Gerd Hoffmann wrote: > Add GUID header file for the QemuRamfbDxe driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > OvmfPkg/Include/Guid/QemuRamfb.h | 25 +++++++++++++++++++++++++ > OvmfPkg/OvmfPkg.dec | 1 + > 2 files changed, 26 insertions(+) > create mode 100644 OvmfPkg/Include/Guid/QemuRamfb.h > > diff --git a/OvmfPkg/Include/Guid/QemuRamfb.h > b/OvmfPkg/Include/Guid/QemuRamfb.h > new file mode 100644 > index 0000000000..878224599d > --- /dev/null > +++ b/OvmfPkg/Include/Guid/QemuRamfb.h > @@ -0,0 +1,25 @@ > +/** @file > + Recommended GUID to be used in the Vendor Hardware device path nodes that > + identify qemu ramfb devices. > + > + Copyright (C) 2018, Red Hat, Inc. > + > + This program and the accompanying materials are licensed and made available > + under the terms and conditions of the BSD License that accompanies this > + distribution. The full text of the license may be found at > + http://opensource.org/licenses/bsd-license.php. > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > WITHOUT > + WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > + > +**/ > + > +#ifndef __QEMU_RAMFB_H__ > +#define __QEMU_RAMFB_H__ > + > +#define QEMU_RAMFB_GUID \ > +{0x837dca9e, 0xe874, 0x4d82, {0xb2, 0x9a, 0x23, 0xfe, 0x0e, 0x23, 0xd1, > 0xe2}} > + > +extern EFI_GUID gQemuRamfbGuid; > + > +#endif > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > index dc5597db41..a16c22a289 100644 > --- a/OvmfPkg/OvmfPkg.dec > +++ b/OvmfPkg/OvmfPkg.dec > @@ -75,6 +75,7 @@ > gEfiXenInfoGuid = {0xd3b46f3b, 0xd441, 0x1244, {0x9a, > 0x12, 0x0, 0x12, 0x27, 0x3f, 0xc1, 0x4d}} > gOvmfPlatformConfigGuid = {0x7235c51c, 0x0c80, 0x4cab, {0x87, > 0xac, 0x3b, 0x08, 0x4a, 0x63, 0x04, 0xb1}} > gVirtioMmioTransportGuid = {0x837dca9e, 0xe874, 0x4d82, {0xb2, > 0x9a, 0x23, 0xfe, 0x0e, 0x23, 0xd1, 0xe2}} > + gQemuRamfbGuid = {0x837dca9e, 0xe874, 0x4d82, {0xb2, > 0x9a, 0x23, 0xfe, 0x0e, 0x23, 0xd1, 0xe2}} > gXenBusRootDeviceGuid = {0xa732241f, 0x383d, 0x4d9c, {0x8a, > 0xe1, 0x8e, 0x09, 0x83, 0x75, 0x89, 0xd7}} > gRootBridgesConnectedEventGroupGuid = {0x24a2d66f, 0xeedd, 0x4086, {0x90, > 0x42, 0xf2, 0x6e, 0x47, 0x97, 0xee, 0x69}} > >
this patch is all good, formally speaking, but you should please generate a new GUID with "uuidgen", rather than using the one from "VirtioMmioTransport.h" :) Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
