On 07/24/18 04:23, Liming Gao wrote: > ResourcePublicationLib class name is ResourcePublicationLib. > INF and DSC files are updated to use the correct one. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao <liming....@intel.com> > Signed-off-by: Dongao Guo <dongao....@intel.com> > --- > OvmfPkg/OvmfPkgIa32.dsc | 2 +- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > OvmfPkg/PlatformPei/PlatformPei.inf | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 7ddda89..a28b511 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -268,7 +268,7 @@ > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf > !endif > PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > - > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > + > ResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > !ifdef $(SOURCE_DEBUG_ENABLE) > > DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 3481cdc..115d0c0 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -273,7 +273,7 @@ > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf > !endif > PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > - > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > + > ResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > !ifdef $(SOURCE_DEBUG_ENABLE) > > DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 8b0895b..362eb78 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -273,7 +273,7 @@ > DebugLib|OvmfPkg/Library/PlatformDebugLibIoPort/PlatformDebugLibIoPort.inf > !endif > PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > - > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > + > ResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiResourcePublicationLib.inf > > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf > !ifdef $(SOURCE_DEBUG_ENABLE) > > DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf > diff --git a/OvmfPkg/PlatformPei/PlatformPei.inf > b/OvmfPkg/PlatformPei/PlatformPei.inf > index 0f347f8..9c5ad99 100644 > --- a/OvmfPkg/PlatformPei/PlatformPei.inf > +++ b/OvmfPkg/PlatformPei/PlatformPei.inf > @@ -58,7 +58,7 @@ > HobLib > IoLib > PciLib > - PeiResourcePublicationLib > + ResourcePublicationLib > PeiServicesLib > PeiServicesTablePointerLib > PeimEntryPoint >
[ler...@redhat.com: insert empty line between commit msg body and tags] Reviewed-by: Laszlo Ersek <ler...@redhat.com> Pushed as commit 0ed73bcdcd80. I notice the same issue affects "ArmVirtPkg/ArmVirt.dsc.inc". However, I think ArmVirtPkg doesn't even build modules that utilize this lib class. (In OVMF, the only such module is PlatformPei, and PlatformPei is extremely specific to the i440fx and q35 machine types of QEMU.) At a closer look, "MdePkg/Include/Library/ResourcePublicationLib.h" only offers one API, namely PublishSystemMemory(). The one and only caller of that API, in the open source edk2 tree, is indeed "OvmfPkg/PlatformPei/MemDetect.c". This suggests I should post a patch to remove the lib class resolution from "ArmVirtPkg/ArmVirt.dsc.inc" altogether. Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
