(add maintainers)
On 25 July 2018 at 21:47, Vladimir Olovyannikov
<vladimir.olovyanni...@broadcom.com> wrote:
> FvSimpleFileSystem on read always allocates a FileBuffer, and never frees
> it. This causes memory leaks. It is especially bad for reading scripts
> line-by-line. In some cases memory leak can exceed 1GB.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Vladimir Olovyannikiov <vladimir.olovyanni...@broadcom.com>
> ---
> .../Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git
> a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> index 746f2ced708a..fde208594737 100644
> --- a/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> +++ b/MdeModulePkg/Universal/FvSimpleFileSystemDxe/FvSimpleFileSystem.c
> @@ -704,6 +704,7 @@ FvSimpleFileSystemRead (
>
> Status = FvFsReadFile (File->Instance->FvProtocol, File->FvFileInfo,
> &FileSize, &FileBuffer);
> if (EFI_ERROR (Status)) {
> + FreePool (FileBuffer);
> return EFI_DEVICE_ERROR;
> }
>
> @@ -714,6 +715,8 @@ FvSimpleFileSystemRead (
> CopyMem (Buffer, (UINT8*)FileBuffer + File->Position, *BufferSize);
> File->Position += *BufferSize;
>
> + FreePool (FileBuffer);
> +
> return EFI_SUCCESS;
> }
> }
> --
> 2.18.0
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
