On 08/03/18 14:15, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: open_file_by_devpath_tiano_1008_v2 > > This is version 2 of the patch set that was originally posted at: > > https://lists.01.org/pipermail/edk2-devel/2018-July/027253.html > > for <https://bugzilla.tianocore.org/show_bug.cgi?id=1008>. > > Changes are noted on every patch. > > The cumulative code difference is very small (not counting the > FrameworkUefiLib copy of the function), so I'm including it here for > easier review: > >> [...]
I should use this opportunity to highlight an awesome community feature from Paolo and Fam (CC'd): the patchew.org website has been tracking edk2 patch submissions for a while: https://patchew.org/ https://patchew.org/EDK2/ and now it offers side-by-side comparison between versions of the same patch set ("interdiff"). For example, the link for this (v2) series is: https://patchew.org/EDK2/20180803121537.32123-1-ler...@redhat.com/ and if you click the "Diff against v1" link, you get: https://patchew.org/EDK2/20180718205043.17574-1-ler...@redhat.com/diff/20180803121537.32123-1-ler...@redhat.com/ I recommend that all edk2 reviewers make use of this feature, for incrementally reviewing patch series. (This is another good reason for keeping the source code lines limited to 80 columns -- if you write 200 character long lines, you won't have a good time looking at side-by-side diffs!) Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
