On Tue, Jul 24, 2018 at 03:09:17PM +0800, Ming Huang wrote:
> From: ZhenYao <yaozh...@huawei.com>
>
> When BIOS booting, the power consumption is too high, so need close
> some clusters clock that don't work to reduce power consumption.
On the one hand: should this not be handled in ARM-TF?
What if (during development) we load a bad EDK2 image?
> The implementation of functions is in edk2-non-osi.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: ZhenYao <yaozh...@huawei.com>
> Signed-off-by: Ming Huang <ming.hu...@linaro.org>
> Signed-off-by: Heyi Guo <heyi....@linaro.org>
> ---
> Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h
> b/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h
> index ec2b9a36e7..cc60e213de 100644
> --- a/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h
> +++ b/Silicon/Hisilicon/Include/Library/PlatformSysCtrlLib.h
> @@ -102,5 +102,8 @@ VOID PlatformEventBroadcastConfig(VOID);
> UINTN GetDjtagRegBase(UINT32 NodeId);
> VOID LlcCleanInvalidateAsm(VOID);
> VOID PlatformMdioInit(VOID);
> +VOID CloseClusterClock(UINTN CpuClusterBase);
The opposite of Enable is Disable. So Could this be DisableClusterClock?
> +VOID EnableClusterClock(UINTN CpuClusterBase);
> +VOID CloseSktClock (UINT8 Skt);
Disable?
Also, Socket, not Skt.
/
Leif
>
> #endif
> --
> 2.17.0
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
