Reviewed-by: Ruiyu Ni <ruiyu...@intel.com> Thanks/Ray
> -----Original Message----- > From: edk2-devel <edk2-devel-boun...@lists.01.org> On Behalf Of shenglei > Sent: Wednesday, August 8, 2018 4:47 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric <eric.d...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: [edk2] [PATCH 21/26] MdeModulePkg TerminalDxe: Remove a > redundant function > > The function UnicodeFiFoGetKeyCount that is never calld has been removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=1062 > > Cc: Star Zeng <star.z...@intel.com> > Cc: Eric Dong <eric.d...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei <shenglei.zh...@intel.com> > --- > .../Universal/Console/TerminalDxe/Terminal.h | 12 --------- > .../Console/TerminalDxe/TerminalConIn.c | 25 ------------------- > 2 files changed, 37 deletions(-) > > diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > index a4543fc8de..84808d55a0 100644 > --- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h > @@ -1131,18 +1131,6 @@ IsUnicodeFiFoFull ( > TERMINAL_DEV *TerminalDevice > ); > > -/** > - Count Unicode FIFO buffer. > - > - @param TerminalDevice Terminal driver private structure > - > - @return The count in bytes of Unicode FIFO. > - > -**/ > -UINT8 > -UnicodeFiFoGetKeyCount ( > - TERMINAL_DEV *TerminalDevice > - ); > > /** > Translate raw data into Unicode (according to different encode), and diff > -- > git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > index 80c4f6b483..33f9b6e585 100644 > --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c > @@ -1200,31 +1200,6 @@ IsUnicodeFiFoFull ( > return FALSE; > } > > -/** > - Count Unicode FIFO buffer. > - > - @param TerminalDevice Terminal driver private structure > - > - @return The count in bytes of Unicode FIFO. > - > -**/ > -UINT8 > -UnicodeFiFoGetKeyCount ( > - TERMINAL_DEV *TerminalDevice > - ) > -{ > - UINT8 Tail; > - UINT8 Head; > - > - Tail = TerminalDevice->UnicodeFiFo->Tail; > - Head = TerminalDevice->UnicodeFiFo->Head; > - > - if (Tail >= Head) { > - return (UINT8) (Tail - Head); > - } else { > - return (UINT8) (Tail + FIFO_MAX_NUMBER + 1 - Head); > - } > -} > > /** > Update the Unicode characters from a terminal input device into EFI Keys > FIFO. > -- > 2.18.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
