Hi Ray, One small comment, below files: \EmulatorPkg\Win\Host\WinGop.h \EmulatorPkg\Win\Host\WinGopInput.c
have an CR line ending (rather than CRLF) at the last line. Please help to correct the format. With the changes, the series is good to me: Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu > Ni > Sent: Thursday, August 23, 2018 5:56 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2 00/12] Add WinHost support in EmulatorPkg > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1112 > > The patch sets add WinHost support (Nt32) in EmulatorPkg. > 3 EmulatorPkg common issues were found and fixed. > Other 9 patches are to step-by-step enable the WinHost. > > v2 sends to correct mail address. > > Ruiyu Ni (12): > EmulatorPkg/ThunkProtocolList: Fix VS build failure > EmulatorPkg/Win: Add Windows host support > EmulatorPkg/Win: Enable source level debugging > EmulatorPkg/Win: Enable native OS console as firmware console > EmulatorPkg/Win: Add input/output support > EmulatorPkg/Win: Add timer and interrupt support > EmulatorPkg/Win: Add RTC support > EmulatorPkg/Win: Add SimpleFileSystem support > EmulatorPkg/Win: Add BlockIo support > EmulatorPkg/PlatformBds: Signal EndOfDxe in platform BDS > EmulatorPkg/EmuFileSystem: Fix a bug that causes Close() assertion > EmulatorPkg/DSC: Remove FS mapping to EDK Shell bin directory > > .../EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c | 33 +- > EmulatorPkg/EmulatorPkg.dsc | 17 +- > EmulatorPkg/Library/EmuBdsLib/BdsPlatform.c | 4 +- > EmulatorPkg/Library/EmuBdsLib/BdsPlatform.h | 4 +- > EmulatorPkg/Library/EmuBdsLib/EmuBdsLib.inf | 5 +- > .../Library/ThunkProtocolList/ThunkProtocolList.c | 4 +- > EmulatorPkg/Win/Host/WinBlockIo.c | 563 +++++ > EmulatorPkg/Win/Host/WinFileSystem.c | 2409 > ++++++++++++++++++++ > EmulatorPkg/Win/Host/WinGop.h | 204 ++ > EmulatorPkg/Win/Host/WinGopInput.c | 417 ++++ > EmulatorPkg/Win/Host/WinGopScreen.c | 872 +++++++ > EmulatorPkg/Win/Host/WinHost.c | 947 ++++++++ > EmulatorPkg/Win/Host/WinHost.h | 209 ++ > EmulatorPkg/Win/Host/WinHost.inf | 107 + > EmulatorPkg/Win/Host/WinInclude.h | 75 + > EmulatorPkg/Win/Host/WinMemoryAllocationLib.c | 178 ++ > EmulatorPkg/Win/Host/WinThunk.c | 577 +++++ > 17 files changed, 6614 insertions(+), 11 deletions(-) > create mode 100644 EmulatorPkg/Win/Host/WinBlockIo.c > create mode 100644 EmulatorPkg/Win/Host/WinFileSystem.c > create mode 100644 EmulatorPkg/Win/Host/WinGop.h > create mode 100644 EmulatorPkg/Win/Host/WinGopInput.c > create mode 100644 EmulatorPkg/Win/Host/WinGopScreen.c > create mode 100644 EmulatorPkg/Win/Host/WinHost.c > create mode 100644 EmulatorPkg/Win/Host/WinHost.h > create mode 100644 EmulatorPkg/Win/Host/WinHost.inf > create mode 100644 EmulatorPkg/Win/Host/WinInclude.h > create mode 100644 EmulatorPkg/Win/Host/WinMemoryAllocationLib.c > create mode 100644 EmulatorPkg/Win/Host/WinThunk.c > > -- > 2.16.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
