Star: The change in MdePkg is good. Because you add two APIs in UefiLib library class, could you also update FrameworkUefiLib in IntelFrameworkPkg?
Thanks Liming > -----Original Message----- > From: Zeng, Star > Sent: Monday, September 17, 2018 5:08 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Younas khan > <pmdyounaskhan...@gmail.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Gao, Liming <liming....@intel.com>; Yao, Jiewen > <jiewen....@intel.com>; Wang, Jian J > <jian.j.w...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Bi, Dandan > <dandan...@intel.com>; Dong, Eric <eric.d...@intel.com>; Laszlo > Ersek <ler...@redhat.com> > Subject: [PATCH V3 0/6] Add new EfiLocateXXXAcpiTable() APIs > > It is the V3 patch series of > https://lists.01.org/pipermail/edk2-devel/2018-August/029214.html > It is according to the discussion at > https://lists.01.org/pipermail/edk2-devel/2018-September/029750.html > > V3: > 1. Pick Ray/Laszlo/Eric's RB. > 2. Remove ASSERT about Signature check. > 3. Merge ScanTableInRSDT and ScanTableInXSDT. > > It is the V2 patch series of > https://lists.01.org/pipermail/edk2-devel/2018-August/029214.html > It is according to the discussion at > https://lists.01.org/pipermail/edk2-devel/2018-September/029348.html > > V2: > 1. Add EfiLocateFirstAcpiTable() and EfiLocateNextAcpiTable() instead > of EfiFindAcpiTableBySignature() to support locating both single > ACPI table instance and multiple ACPI table instances cases. > 2. Support locating DSDT. > 3. Support locating multiple ACPI table instances case by > EfiLocateNextAcpiTable(). > > Test done: > 1. Call EfiLocateFirstAcpiTable() before ACPI configuration table is > installed, NULL is returned. > 2. Call EfiLocateFirstAcpiTable() to locate FACS after FACS is installed > but FADT is not installed, NULL is returned. > 3. Call EfiLocateFirstAcpiTable() to locate FADT/DSDT/FACS/FPDT/DMAR > at late phase, correct ACPI table pointer is returned. > 4. Call EfiLocateNextAcpiTable() to locate SSDTs at late phase, all > SSDTs are returned correctly. > 5. Run same test cases above after setting PcdAcpiExposedTableVersions > to 0x2, same results are with above. > 6. Run same test cases above with 32Bits build, same results are with > above. > > The code for this patch series is also at > g...@github.com:lzeng14/edk2.git branch LocateAcpiTable_UefiLibV3 > > https://bugzilla.tianocore.org/show_bug.cgi?id=967 > Request to add a library function for GetAcpiTable() in order > to get ACPI table using signature as input. > > After evaluation, we found there are many duplicated code to > find ACPI table by signature in different modules. > > This patch adds new EfiLocateXXXAcpiTable() API in UefiLib > for the request and removing the duplicated code. > > Cc: Younas khan <pmdyounaskhan...@gmail.com> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Ruiyu Ni <ruiyu...@intel.com> > Cc: Dandan Bi <dandan...@intel.com> > Cc: Eric Dong <eric.d...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > > Star Zeng (6): > MdePkg UefiLib: Add new EfiLocateXXXAcpiTable() APIs > IntelSiliconPkg IntelVTdDxe: Use new EfiLocateFirstAcpiTable() > MdeModulePkg S3SaveStateDxe: Use new EfiLocateFirstAcpiTable() > PcAtChipsetPkg PcRtc: Use new EfiLocateFirstAcpiTable() > ShellPkg DpDynamicCommand: Use new EfiLocateFirstAcpiTable() > UefiCpuPkg PiSmmCpuDxeSmm: Use new EfiLocateFirstAcpiTable() > > .../Feature/VTd/IntelVTdDxe/DmarAcpiTable.c | 136 +------ > .../Acpi/S3SaveStateDxe/AcpiS3ContextSave.c | 208 +--------- > .../Acpi/S3SaveStateDxe/S3SaveStateDxe.inf | 3 +- > MdePkg/Include/Library/UefiLib.h | 68 ++++ > MdePkg/Library/UefiLib/Acpi.c | 428 > +++++++++++++++++++++ > MdePkg/Library/UefiLib/UefiLib.inf | 3 + > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c | 80 +--- > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 136 +------ > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.h | 1 - > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.uni | 1 - > ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf | 2 - > .../DpDynamicCommand/DpDynamicCommand.inf | 2 - > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 4 +- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 84 +--- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h | 3 +- > 15 files changed, 519 insertions(+), 640 deletions(-) > create mode 100644 MdePkg/Library/UefiLib/Acpi.c > > -- > 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
