On 09/25/18 03:11, Jiaxin Wu wrote: > *v2: Rename and redefine the PCD in NetworkPkg instead of MdeModulePkg. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=886 > > This patch is to define one new PCD for PXE driver to specify MTFTP > windowsize so as > to improve the PXE download performance. The default value is set to 4. > > Cc: Ye Ting <ting...@intel.com> > Cc: Fu Siyuan <siyuan...@intel.com> > Cc: Shao Ming <ming.s...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin <jiaxin...@intel.com> > --- > NetworkPkg/NetworkPkg.dec | 6 ++++++ > NetworkPkg/NetworkPkg.uni | 6 ++++++ > 2 files changed, 12 insertions(+)
git-am complained about trailing whitespace: > diff --git a/NetworkPkg/NetworkPkg.dec b/NetworkPkg/NetworkPkg.dec > index aae36226d5..aa721d8315 100644 > --- a/NetworkPkg/NetworkPkg.dec > +++ b/NetworkPkg/NetworkPkg.dec > @@ -90,10 +90,16 @@ > # TRUE - HTTP connections are allowed. Both the "https://"; and "http://"; > URI schemes are permitted. > # FALSE - HTTP connections are denied. Only the "https://"; URI scheme is > permitted. > # @Prompt Indicates whether HTTP connections are permitted or not. > > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|FALSE|BOOLEAN|0x00000008 > > + ## This setting is to specify the MTFTP windowsize used by UEFI PXE > driver. (1) here > + # A value of 0 indicates the default value of windowsize(1). (2) here > + # A non-zero value will be used as windowsize. > + # @Prompt PXE TFTP windowsize. > + gEfiNetworkPkgTokenSpaceGuid.PcdPxeTftpWindowSize|0x4|UINT64|0x10000008 (3) here > + > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## IPv6 DHCP Unique Identifier (DUID) Type configuration (From RFCs 3315 > and 6355). > # 01 = DUID Based on Link-layer Address Plus Time [DUID-LLT] > # 04 = UUID-Based DHCPv6 Unique Identifier (DUID-UUID) > # 02 = DUID Assigned by Vendor Based on Enterprise Number [DUID-EN] (not > supported) > diff --git a/NetworkPkg/NetworkPkg.uni b/NetworkPkg/NetworkPkg.uni > index 5604b1bf32..07585680e3 100644 > --- a/NetworkPkg/NetworkPkg.uni > +++ b/NetworkPkg/NetworkPkg.uni > @@ -53,10 +53,16 @@ > > #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdAllowHttpConnections_HELP > #language en-US "Indicates whether HTTP connections are permitted or not.\n" > > "TRUE - HTTP connections are allowed.\n" > > "FALSE - HTTP connections are denied." > > +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdPxeTftpWindowSize_PROMPT > #language en-US "This setting is to specify the MTFTP windowsize used by UEFI > PXE driver." > + > +#string STR_gEfiNetworkPkgTokenSpaceGuid_PcdPxeTftpWindowSize_HELP > #language en-US "Specify MTFTP windowsize used by UEFI PXE driver.\n" > + > "A value of 0 indicates the default value of windowsize(1).\n" > + > "A non-zero value will be used as windowsize." > (4) and here. With those fixed: Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks Laszlo > + > #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIpsecCertificateEnabled_PROMPT > #language en-US "Enable IPsec IKEv2 Certificate Authentication." > > #string STR_gEfiNetworkPkgTokenSpaceGuid_PcdIpsecCertificateEnabled_HELP > #language en-US "Indicates if the IPsec IKEv2 Certificate Authentication > feature is enabled or not.<BR><BR>\n" > > "TRUE - Certificate Authentication feature is enabled.<BR>\n" > > "FALSE - Does not support Certificate Authentication.<BR>" > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
