Good news. -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Wednesday, September 26, 2018 4:01 PM To: Zeng, Star <star.z...@intel.com> Cc: Ni, Ruiyu <ruiyu...@intel.com>; Tian, Feng <feng.t...@intel.com>; Wang, Fei1 <fei1.w...@intel.com>; Grzegorz Jaszczyk <j...@semihalf.com>; edk2-devel@lists.01.org; Nadav Haklai <nad...@marvell.com>; Gao, Liming <liming....@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: Re: [edk2] [PATCH v2] MdeModulePkg: XhciDxe: Prevent illegal memory access in XhcSetHsee
On Wed, 26 Sep 2018 at 02:36, Zeng, Star <star.z...@intel.com> wrote: > > Just pushed it at e5cd809087e5710e019d2766fab13c59a2e2ac28. > Really thanks. > FYI this patch fixes the issue with my PCIe Renesas uPD70201 XHCI controller as well. > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, September 26, 2018 8:30 AM > To: Marcin Wojtas <m...@semihalf.com>; edk2-devel@lists.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Gao, Liming <liming....@intel.com>; > leif.lindh...@linaro.org; ard.biesheu...@linaro.org; > nad...@marvell.com; j...@semihalf.com; j...@semihalf.com; Ni, Ruiyu > <ruiyu...@intel.com>; Wang, Fei1 <fei1.w...@intel.com>; Zeng, Star > <star.z...@intel.com> > Subject: RE: [PATCH v2] MdeModulePkg: XhciDxe: Prevent illegal memory > access in XhcSetHsee > > Good observation. > > Reviewed-by: Star Zeng <star.z...@intel.com> > > > Thanks, > Star > -----Original Message----- > From: Marcin Wojtas [mailto:m...@semihalf.com] > Sent: Wednesday, September 26, 2018 5:58 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng <feng.t...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Gao, Liming <liming....@intel.com>; > leif.lindh...@linaro.org; ard.biesheu...@linaro.org; > nad...@marvell.com; m...@semihalf.com; j...@semihalf.com; > j...@semihalf.com; Ni, Ruiyu <ruiyu...@intel.com>; Wang, Fei1 > <fei1.w...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: [PATCH v2] MdeModulePkg: XhciDxe: Prevent illegal memory > access in XhcSetHsee > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1206 > > Newly added XhcSetHsee() routine reads 4 bytes into a UINT16 variable causing > issues on PCIE and NonDiscoverable Xhci controllers. Fix that. > > Cc: Ruiyu Ni <ruiyu...@intel.com> > Cc: Fei1 Wang <fei1.w...@intel.com> > Cc: Star Zeng <star.z...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas <m...@semihalf.com> > --- > MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c > index 89f073e..3ed1a55 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciReg.c > @@ -609,7 +609,7 @@ XhcSetHsee ( > PciIo, > EfiPciIoWidthUint16, > PCI_COMMAND_OFFSET, > - sizeof (XhciCmd), > + sizeof (XhciCmd) / sizeof (UINT16), > &XhciCmd > ); > if (!EFI_ERROR (Status)) { > -- > 2.7.4 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
