On 10/02/18 13:55, Laszlo Ersek wrote: > On 10/02/18 13:37, Marc-André Lureau wrote: >> On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek <ler...@redhat.com> wrote: > >>> Please fix your git settings for your local edk2 clone. Your patch >>> contains context lines with LF (not CRLF) line endings, and that's not >>> correct for edk2. >> >> Shouldn't it be catched by: python BaseTools/Scripts/PatchCheck.py -1 ? > > Yes, it should be caught by "PatchCheck.py". The "force_crlf" member is > set iff the pathname doesn't end in ".sh", and then the > check_added_line() method verifies CRLF. > > I don't know why it doesn't work in practice. Can you submit a TianoCore > BZ about it?
Nevermind: > You are right, the attachment looks fine. ... so that's the reason "PatchCheck.py" does not complain. Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
