Reviewed-by: Star Zeng <star.z...@intel.com> -----Original Message----- From: Gao, Liming Sent: Monday, October 8, 2018 10:52 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org Subject: RE: [edk2] [Patch 0/2] Update BrotliCompress to the latest version 1.0.5
Star: Thank you for review. I just find Brotli 1.0.6 has been released. Based on v1.0.5, there is the minor change in source file. They have no functionality impact. I have pushed the additional patches in https://github.com/lgao4/edk2/tree/Brotli to integrate 1.0.6 change. Could you help review them? After review, I will combine the patches to single serial to update BrotliCompress to the latest version 1.0.6. Thanks Liming > -----Original Message----- > From: Zeng, Star > Sent: Monday, October 8, 2018 9:37 AM > To: Gao, Liming <liming....@intel.com>; edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com> > Subject: RE: [edk2] [Patch 0/2] Update BrotliCompress to the latest > version 1.0.5 > > Reviewed-by: Star Zeng <star.z...@intel.com> > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Liming Gao > Sent: Monday, September 10, 2018 8:37 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/2] Update BrotliCompress to the latest > version 1.0.5 > > Because the patch is too big, the change is placed in > https://github.com/lgao4/edk2/tree/Brotli > > Update Brotli to the latest version 1.0.5 > https://github.com/google/brotli Verify VS2017, GCC5 build. > Verify Decompression boot functionality. > > Liming Gao (2): > BaseTools: Update Brotli Compress to the latest one 1.0.5 > MdeModulePkg: Update Brotli DecompressLib to the latest v1.0.5 > > BaseTools/BinWrappers/PosixLike/BrotliCompress | 13 +- > .../WindowsLike}/BrotliCompress.bat | 12 +- > BaseTools/Source/C/BrotliCompress/GNUmakefile | 8 +- > BaseTools/Source/C/BrotliCompress/Makefile | 20 +- > BaseTools/Source/C/BrotliCompress/ReadMe.txt | 2 +- > .../Source/C/BrotliCompress/common/constants.h | 25 +- > .../Source/C/BrotliCompress/common}/context.h | 356 +- > .../Source/C/BrotliCompress/common/dictionary.c | 15341 +++++++---------- > .../Source/C/BrotliCompress/common/dictionary.h | 47 +- > .../Source/C/BrotliCompress/common/platform.h | 509 + > BaseTools/Source/C/BrotliCompress/common/port.h | 107 - > .../Source/C/BrotliCompress/common/transform.c | 235 + > .../Source/C/BrotliCompress/common/transform.h | 80 + > BaseTools/Source/C/BrotliCompress/common/types.h | 58 - > BaseTools/Source/C/BrotliCompress/common/version.h | 26 + > BaseTools/Source/C/BrotliCompress/dec/bit_reader.c | 6 +- > BaseTools/Source/C/BrotliCompress/dec/bit_reader.h | 162 +- > BaseTools/Source/C/BrotliCompress/dec/decode.c | 1208 +- > BaseTools/Source/C/BrotliCompress/dec/decode.h | 188 - > BaseTools/Source/C/BrotliCompress/dec/huffman.c | 59 +- > BaseTools/Source/C/BrotliCompress/dec/huffman.h | 24 +- > BaseTools/Source/C/BrotliCompress/dec/port.h | 159 - > BaseTools/Source/C/BrotliCompress/dec/prefix.h | 9 +- > BaseTools/Source/C/BrotliCompress/dec/state.c | 90 +- > BaseTools/Source/C/BrotliCompress/dec/state.h | 82 +- > BaseTools/Source/C/BrotliCompress/dec/transform.h | 300 - > .../C/BrotliCompress/enc/backward_references.c | 822 +- > .../C/BrotliCompress/enc/backward_references.h | 77 +- > .../C/BrotliCompress/enc/backward_references_hq.c | 830 + > .../C/BrotliCompress/enc/backward_references_hq.h | 93 + > .../C/BrotliCompress/enc/backward_references_inc.h | 70 +- > BaseTools/Source/C/BrotliCompress/enc/bit_cost.c | 4 +- > BaseTools/Source/C/BrotliCompress/enc/bit_cost.h | 12 +- > .../C/BrotliCompress/enc/block_encoder_inc.h | 13 +- > .../Source/C/BrotliCompress/enc/block_splitter.c | 11 +- > .../Source/C/BrotliCompress/enc/block_splitter.h | 4 +- > .../C/BrotliCompress/enc/block_splitter_inc.h | 35 +- > .../C/BrotliCompress/enc/brotli_bit_stream.c | 223 +- > .../C/BrotliCompress/enc/brotli_bit_stream.h | 63 +- > BaseTools/Source/C/BrotliCompress/enc/cluster.c | 4 +- > BaseTools/Source/C/BrotliCompress/enc/cluster.h | 4 +- > .../Source/C/BrotliCompress/enc/cluster_inc.h | 2 + > BaseTools/Source/C/BrotliCompress/enc/command.h | 83 +- > .../C/BrotliCompress/enc/compress_fragment.c | 189 +- > .../C/BrotliCompress/enc/compress_fragment.h | 9 +- > .../enc/compress_fragment_two_pass.c | 296 +- > .../enc/compress_fragment_two_pass.h | 9 +- > BaseTools/Source/C/BrotliCompress/enc/compressor.h | 161 - > BaseTools/Source/C/BrotliCompress/enc/context.h | 184 - > .../Source/C/BrotliCompress/enc/dictionary_hash.c | 1120 ++ > .../Source/C/BrotliCompress/enc/dictionary_hash.h | 4101 +---- > BaseTools/Source/C/BrotliCompress/enc/encode.c | 1050 +- > BaseTools/Source/C/BrotliCompress/enc/encode.h | 221 - > .../Source/C/BrotliCompress/enc/encode_parallel.h | 27 - > .../Source/C/BrotliCompress/enc/encoder_dict.c | 32 + > .../Source/C/BrotliCompress/enc/encoder_dict.h | 41 + > .../Source/C/BrotliCompress/enc/entropy_encode.c | 46 +- > .../Source/C/BrotliCompress/enc/entropy_encode.h | 18 +- > .../C/BrotliCompress/enc/entropy_encode_static.h | 10 +- > BaseTools/Source/C/BrotliCompress/enc/fast_log.h | 8 +- > .../C/BrotliCompress/enc/find_match_length.h | 22 +- > BaseTools/Source/C/BrotliCompress/enc/hash.h | 732 +- > .../C/BrotliCompress/enc/hash_composite_inc.h | 133 + > .../BrotliCompress/enc/hash_forgetful_chain_inc.h | 145 +- > .../BrotliCompress/enc/hash_longest_match64_inc.h | 266 + > .../C/BrotliCompress/enc/hash_longest_match_inc.h | 229 +- > .../enc/hash_longest_match_quickly_inc.h | 163 +- > .../Source/C/BrotliCompress/enc/hash_rolling_inc.h | 215 + > .../C/BrotliCompress/enc/hash_to_binary_tree_inc.h | 327 + > BaseTools/Source/C/BrotliCompress/enc/histogram.c | 13 +- > BaseTools/Source/C/BrotliCompress/enc/histogram.h | 11 +- > .../Source/C/BrotliCompress/enc/histogram_inc.h | 2 +- > .../Source/C/BrotliCompress/enc/literal_cost.c | 21 +- > .../Source/C/BrotliCompress/enc/literal_cost.h | 8 +- > BaseTools/Source/C/BrotliCompress/enc/memory.c | 23 +- > BaseTools/Source/C/BrotliCompress/enc/memory.h | 46 +- > BaseTools/Source/C/BrotliCompress/enc/metablock.c | 427 +- > BaseTools/Source/C/BrotliCompress/enc/metablock.h | 35 +- > .../Source/C/BrotliCompress/enc/metablock_inc.h | 2 +- > BaseTools/Source/C/BrotliCompress/enc/params.h | 44 + > BaseTools/Source/C/BrotliCompress/enc/port.h | 168 - > BaseTools/Source/C/BrotliCompress/enc/prefix.h | 11 +- > BaseTools/Source/C/BrotliCompress/enc/quality.h | 91 +- > BaseTools/Source/C/BrotliCompress/enc/ringbuffer.h | 38 +- > .../Source/C/BrotliCompress/enc/static_dict.c | 118 +- > .../Source/C/BrotliCompress/enc/static_dict.h | 9 +- > .../Source/C/BrotliCompress/enc/static_dict_lut.h | 17035 > +++++++------------ > BaseTools/Source/C/BrotliCompress/enc/streams.h | 121 - > BaseTools/Source/C/BrotliCompress/enc/utf8_util.c | 42 +- > BaseTools/Source/C/BrotliCompress/enc/utf8_util.h | 6 +- > BaseTools/Source/C/BrotliCompress/enc/write_bits.h | 41 +- > .../C/BrotliCompress/include/brotli/decode.h | 344 + > .../C/BrotliCompress/include/brotli/encode.h | 427 + > .../Source/C/BrotliCompress/include/brotli/port.h | 274 + > .../Source/C/BrotliCompress/include/brotli/types.h | 83 + > BaseTools/Source/C/BrotliCompress/tools/bro.c | 554 - > BaseTools/Source/C/BrotliCompress/tools/brotli.c | 1067 ++ > BaseTools/Source/C/BrotliCompress/tools/brotli.md | 107 + > BaseTools/Source/C/BrotliCompress/tools/version.h | 14 - > .../BrotliCustomDecompressLib.inf | 14 + > .../BrotliCustomDecompressLib/BrotliDecompress.c | 26 +- > .../BrotliDecompressLibInternal.h | 4 +- > .../Library/BrotliCustomDecompressLib/ReadMe.txt | 2 +- > .../BrotliCustomDecompressLib/brotli/decode.h | 344 + > .../BrotliCustomDecompressLib/brotli/port.h | 274 + > .../BrotliCustomDecompressLib/brotli/types.h | 96 + > .../BrotliCustomDecompressLib/common/constants.h | 25 +- > .../BrotliCustomDecompressLib/common}/context.h | 356 +- > .../BrotliCustomDecompressLib/common/dictionary.c | 15341 +++++++---------- > .../BrotliCustomDecompressLib/common/dictionary.h | 47 +- > .../BrotliCustomDecompressLib/common/platform.h | 510 + > .../BrotliCustomDecompressLib/common/port.h | 107 - > .../BrotliCustomDecompressLib/common/transform.c | 235 + > .../BrotliCustomDecompressLib/common/transform.h | 80 + > .../BrotliCustomDecompressLib/common/types.h | 72 - > .../BrotliCustomDecompressLib/common/version.h | 26 + > .../BrotliCustomDecompressLib/dec/bit_reader.c | 6 +- > .../BrotliCustomDecompressLib/dec/bit_reader.h | 163 +- > .../Library/BrotliCustomDecompressLib/dec/decode.c | 1222 +- > .../Library/BrotliCustomDecompressLib/dec/decode.h | 188 - > .../BrotliCustomDecompressLib/dec/huffman.c | 59 +- > .../BrotliCustomDecompressLib/dec/huffman.h | 25 +- > .../Library/BrotliCustomDecompressLib/dec/port.h | 159 - > .../Library/BrotliCustomDecompressLib/dec/prefix.h | 9 +- > .../Library/BrotliCustomDecompressLib/dec/state.c | 91 +- > .../Library/BrotliCustomDecompressLib/dec/state.h | 82 +- > .../BrotliCustomDecompressLib/dec/transform.h | 300 - > 127 files changed, 30174 insertions(+), 42101 deletions(-) rename > BaseTools/{Source/C/BrotliCompress => > BinWrappers/WindowsLike}/BrotliCompress.bat (76%) rename > {MdeModulePkg/Library/BrotliCustomDecompressLib/dec => > BaseTools/Source/C/BrotliCompress/common}/context.h (58%) create mode > 100644 BaseTools/Source/C/BrotliCompress/common/platform.h > delete mode 100644 BaseTools/Source/C/BrotliCompress/common/port.h > create mode 100644 > BaseTools/Source/C/BrotliCompress/common/transform.c > create mode 100644 > BaseTools/Source/C/BrotliCompress/common/transform.h > delete mode 100644 BaseTools/Source/C/BrotliCompress/common/types.h > create mode 100644 BaseTools/Source/C/BrotliCompress/common/version.h > delete mode 100644 BaseTools/Source/C/BrotliCompress/dec/decode.h > delete mode 100644 BaseTools/Source/C/BrotliCompress/dec/port.h > delete mode 100644 BaseTools/Source/C/BrotliCompress/dec/transform.h > create mode 100644 > BaseTools/Source/C/BrotliCompress/enc/backward_references_hq.c > create mode 100644 > BaseTools/Source/C/BrotliCompress/enc/backward_references_hq.h > delete mode 100644 BaseTools/Source/C/BrotliCompress/enc/compressor.h > delete mode 100644 BaseTools/Source/C/BrotliCompress/enc/context.h > create mode 100644 > BaseTools/Source/C/BrotliCompress/enc/dictionary_hash.c > delete mode 100644 BaseTools/Source/C/BrotliCompress/enc/encode.h > delete mode 100644 > BaseTools/Source/C/BrotliCompress/enc/encode_parallel.h > create mode 100644 > BaseTools/Source/C/BrotliCompress/enc/encoder_dict.c > create mode 100644 > BaseTools/Source/C/BrotliCompress/enc/encoder_dict.h > create mode 100644 > BaseTools/Source/C/BrotliCompress/enc/hash_composite_inc.h > create mode 100644 > BaseTools/Source/C/BrotliCompress/enc/hash_longest_match64_inc.h > create mode 100644 > BaseTools/Source/C/BrotliCompress/enc/hash_rolling_inc.h > create mode 100644 > BaseTools/Source/C/BrotliCompress/enc/hash_to_binary_tree_inc.h > create mode 100644 BaseTools/Source/C/BrotliCompress/enc/params.h > delete mode 100644 BaseTools/Source/C/BrotliCompress/enc/port.h > delete mode 100644 BaseTools/Source/C/BrotliCompress/enc/streams.h > create mode 100644 > BaseTools/Source/C/BrotliCompress/include/brotli/decode.h > create mode 100644 > BaseTools/Source/C/BrotliCompress/include/brotli/encode.h > create mode 100644 > BaseTools/Source/C/BrotliCompress/include/brotli/port.h > create mode 100644 > BaseTools/Source/C/BrotliCompress/include/brotli/types.h > delete mode 100644 BaseTools/Source/C/BrotliCompress/tools/bro.c > create mode 100644 BaseTools/Source/C/BrotliCompress/tools/brotli.c > create mode 100644 BaseTools/Source/C/BrotliCompress/tools/brotli.md > delete mode 100644 BaseTools/Source/C/BrotliCompress/tools/version.h > create mode 100644 > MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/decode.h > create mode 100644 > MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/port.h > create mode 100644 > MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/types.h > rename {BaseTools/Source/C/BrotliCompress/dec => > MdeModulePkg/Library/BrotliCustomDecompressLib/common}/context.h (58%) > create mode 100644 > MdeModulePkg/Library/BrotliCustomDecompressLib/common/platform.h > delete mode 100644 > MdeModulePkg/Library/BrotliCustomDecompressLib/common/port.h > create mode 100644 > MdeModulePkg/Library/BrotliCustomDecompressLib/common/transform.c > create mode 100644 > MdeModulePkg/Library/BrotliCustomDecompressLib/common/transform.h > delete mode 100644 > MdeModulePkg/Library/BrotliCustomDecompressLib/common/types.h > create mode 100644 > MdeModulePkg/Library/BrotliCustomDecompressLib/common/version.h > delete mode 100644 > MdeModulePkg/Library/BrotliCustomDecompressLib/dec/decode.h > delete mode 100644 > MdeModulePkg/Library/BrotliCustomDecompressLib/dec/port.h > delete mode 100644 > MdeModulePkg/Library/BrotliCustomDecompressLib/dec/transform.h > > -- > 2.10.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
