Series Reviewed-by: Star Zeng <star.z...@intel.com>
Thanks, Star -----Original Message----- From: Wu, Hao A Sent: Tuesday, October 16, 2018 4:15 PM To: edk2-devel@lists.01.org Cc: Wu, Hao A <hao.a...@intel.com>; Paulo Alcantara <palcant...@suse.de>; Paulo Alcantara <pa...@paulo.ac>; Ni, Ruiyu <ruiyu...@intel.com>; Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen....@intel.com> Subject: [PATCH v2 0/6] Code refinements in UdfDxe Note: Since PATCH v2 1/6 ~ 5/6 have not been changed, add the 'Reviewed-by:' tag during the v1 series review. V2 changes: A. Drop PATCH v1 6/7, since removing those codes will make the function MangleFileName() not matching its original implementation purpose (according to the function description). B. Drop change C in PATCH v1 7/7. It is reasonable for function SetFileInfo() to handle the expected value for the input parameters. C. Refine the log message for PATCH v1 7/7. V1 history: This series will refine the codes in MdeModulePkg/Universal/Disk/UdfDxe for: A. Refine asserts used for memory allocation failure and error cases that are possible to happen. Will use error handling logic for them; B. Address some dead codes within this module. Cc: Paulo Alcantara <palcant...@suse.de> Cc: Paulo Alcantara <pa...@paulo.ac> Cc: Ruiyu Ni <ruiyu...@intel.com> Cc: Star Zeng <star.z...@intel.com> Cc: Jiewen Yao <jiewen....@intel.com> Hao Wu (6): MdeModulePkg/UdfDxe: Use error handling for memory allocation failure MdeModulePkg/UdfDxe: ASSERT for false positives of NULL ptr deref MdeModulePkg/UdfDxe: Use error handling when fail to return LSN MdeModulePkg/UdfDxe: Use debug msg instead of ASSERT in UdfOpen() MdeModulePkg/UdfDxe: Handle dead codes in File.c MdeModulePkg/UdfDxe: Handle dead codes in FileSystemOperations.c MdeModulePkg/Universal/Disk/UdfDxe/File.c | 19 ++- MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 158 +++++++++++++++----- 2 files changed, 138 insertions(+), 39 deletions(-) -- 2.12.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
