(On further thinking, and testing ...) Could you also make sure D03/D05 ACPI is up to date and builds with acpica 20181003? I think anything that compiles with 20180629 should also work with 20181003.
Best Regards, Leif On Mon, Oct 29, 2018 at 06:58:46PM +0000, Leif Lindholm wrote: > Hi Ming, > > A while back, I forwarded to Al Stone (on cc) the issues we were > having with different versions of acpica-tools and the D06 ACPI table > generation. > > He's come back with a few bugs he found in the .asl, as well as a > weird bug in iasl ... apparently only reproducible under Fedora. > Since the latter has not been fully investigated yet, I'll ignore that > until someone flags this as an issue for them. > > I'm attaching a simple patch that resolves all the issues on current > master. Can you please turn this into a proper patch and send out > (giving Al a Reported-by:)? > > Main gist is reformatting some of the IORT into a form the current > acpica-tools can handle, but there are also some bugfixes and closing > of comment blocks. > > Once I have given feedback for v1 of your edk2-platforms series, > please rebase that onto a version that incorporates these fixes for > v2. > > Best Regards, > > Leif > > From 5651683495f3d36c886f97db17976c9a6eac7b47 Mon Sep 17 00:00:00 2001 > From: Leif Lindholm <leif.lindh...@linaro.org> > Date: Mon, 29 Oct 2018 16:34:23 +0000 > Subject: [PATCH edk2-platforms] ahs3-fixes > > --- > Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl | 32 > +++++++------------- > Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620IortNoSmmu.asl | 2 ++ > 2 files changed, 13 insertions(+), 21 deletions(-) > > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl > b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl > index 33b5d5250b..4037ea4f1b 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl > +++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620Iort.asl > @@ -53,9 +53,7 @@ > [0004] PRI Interrupt : 00000000 > [0004] GERR Interrupt : 00000000 > [0004] Sync Interrupt : 00000000 > -[0001] Proximity Domain : 01 > -[0001] Reserved : 00 > -[0002] Reserved : 0000 > +[0001] Proximity Domain : 00000001 > [0004] DeviceID mapping index : 00000002 > > [0004] Input base : 00000000 > @@ -99,9 +97,7 @@ > [0004] PRI Interrupt : 00000000 > [0004] GERR Interrupt : 00000000 > [0004] Sync Interrupt : 00000000 > -[0001] Proximity Domain : 01 > -[0001] Reserved : 00 > -[0002] Reserved : 0000 > +[0001] Proximity Domain : 00000001 > [0004] DeviceID mapping index : 0001 > > [0004] Input base : 00007c00 > @@ -139,9 +135,7 @@ > [0004] PRI Interrupt : 00000000 > [0004] GERR Interrupt : 00000000 > [0004] Sync Interrupt : 00000000 > -[0001] Proximity Domain : 01 > -[0001] Reserved : 00 > -[0002] Reserved : 0000 > +[0001] Proximity Domain : 00000001 > [0004] DeviceID mapping index : 00000001 > > [0004] Input base : 00007400 > @@ -179,9 +173,7 @@ > [0004] PRI Interrupt : 00000000 > [0004] GERR Interrupt : 00000000 > [0004] Sync Interrupt : 00000000 > -[0001] Proximity Domain : 03 > -[0001] Reserved : 00 > -[0002] Reserved : 0000 > +[0001] Proximity Domain : 00000003 > [0004] DeviceID mapping index : 00000002 > > [0004] Input base : 00008000 > @@ -225,9 +217,7 @@ > [0004] PRI Interrupt : 00000000 > [0004] GERR Interrupt : 00000000 > [0004] Sync Interrupt : 00000000 > -[0001] Proximity Domain : 03 > -[0001] Reserved : 00 > -[0002] Reserved : 0000 > +[0001] Proximity Domain : 00000003 > [0004] DeviceID mapping index : 0001 > > [0004] Input base : 0000BC00 > @@ -265,9 +255,7 @@ > [0004] PRI Interrupt : 00000000 > [0004] GERR Interrupt : 00000000 > [0004] Sync Interrupt : 00000000 > -[0001] Proximity Domain : 03 > -[0001] Reserved : 00 > -[0002] Reserved : 0000 > +[0001] Proximity Domain : 00000003 > [0004] DeviceID mapping index : 00000001 > > [0004] Input base : 0000B400 > @@ -290,7 +278,7 @@ > [0001] Revision : 00 > [0004] Reserved : 00000000 > [0004] Mapping Count : 0000000C > -[0004] Mapping Offset : 00000028 > +[0004] Mapping Offset : 00000024 > > [0008] Memory Properties : [IORT Memory Access Properties] > [0004] Cache Coherency : 00000001 > @@ -305,6 +293,8 @@ > Device Attribute : 0 > [0004] ATS Attribute : 00000000 > [0004] PCI Segment Number : 00000000 // should > match with above MCFG > + Memory Size Limit : 00 > + Reserved : 00000000 > > /* BDF of pcie host 0 -> stream ID of pcie 0/1 SMMU */ > [0004] Input base : 00000000 > @@ -322,7 +312,7 @@ > [0004] Flags (decoded below) : 00000000 > Single Mapping : 1 > > -/* host2 and host3 should no open smmu for chips smmu bug * > +/* host2 and host3 should no open smmu for chips smmu bug */ > /* BDF of pcie host 2 -> stream ID of pcie 0/1 ITS */ > [0004] Input base : 00007a00 > [0004] ID Count : 00000100 // the number > of IDs in range > @@ -371,7 +361,7 @@ > [0004] Flags (decoded below) : 00000000 > Single Mapping : 1 > > -/* host8 and host9 should no open smmu for chips smmu bug * > +/* host8 and host9 should no open smmu for chips smmu bug */ > /* BDF of pcie host 8 -> stream ID of pcie ITS */ > [0004] Input base : 0000BA00 > [0004] ID Count : 00000100 // the number > of IDs in range > diff --git a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620IortNoSmmu.asl > b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620IortNoSmmu.asl > index 63d11b83eb..f4bef6ec89 100644 > --- a/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620IortNoSmmu.asl > +++ b/Silicon/Hisilicon/Hi1620/Hi1620AcpiTables/Hi1620IortNoSmmu.asl > @@ -54,6 +54,8 @@ > Device Attribute : 0 > [0004] ATS Attribute : 00000000 > [0004] PCI Segment Number : 00000000 // should > match with above MCFG > + Memory Size Limit : 00 > + Reserved : 00000000 > > /* BDF of pcie host 0 -> stream ID of pcie 0/1 SMMU */ > [0004] Input base : 00000000 > -- > 2.11.0 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
