Thanks for your comments about 'USE_OLD_SHELL'. I'll improve the patches in next version.
Shenglei > -----Original Message----- > From: Justen, Jordan L > Sent: Wednesday, October 31, 2018 2:48 PM > To: edk2-devel@lists.01.org; Zhang, Shenglei <shenglei.zh...@intel.com> > Subject: Re: [edk2] [PATCH 0/5] Remove EdkShellBinPkg in FDF, DSC and DEC > > I also see USE_OLD_SHELL references in the .dsc files. > > (Try 'git grep USE_OLD_SHELL') > > After the platforms no longer reference EdkShellBinPkg, then the bin > package will be removed? > > -Jordan > > On 2018-10-30 22:57:06, shenglei wrote: > > Remove EdkShellBinPkg in CorebootPayloadPkg, EmulatorPkg, Nt32Pkg > > and OvmfPkg. Replace EdkShellBinPkg with EdkShellPkg in > > Vlv2TbltDevicePkg. > > > > shenglei (5): > > CorebootPayloadPkg: Remove EdkShellBinPkg in FDF > > EmulatorPkg: Remove EdkShellBinPkg in FDF and DEC > > Nt32Pkg: Remove EdkShellBinPkg in FDF,DSC and DEC > > OvmfPkg: Remove EdkShellBinPkg in FDF > > Vlv2TbltDevicePkg: Remove EdkShellBinPkg with ShellPkg > > > > CorebootPayloadPkg/CorebootPayloadPkg.fdf | 8 -------- > > EmulatorPkg/EmulatorPkg.dec | 2 +- > > EmulatorPkg/EmulatorPkg.fdf | 4 ---- > > Nt32Pkg/Nt32Pkg.dec | 2 +- > > Nt32Pkg/Nt32Pkg.dsc | 4 ++-- > > Nt32Pkg/Nt32Pkg.fdf | 4 ---- > > OvmfPkg/OvmfPkgIa32.fdf | 4 ---- > > OvmfPkg/OvmfPkgIa32X64.fdf | 4 ---- > > OvmfPkg/OvmfPkgX64.fdf | 4 ---- > > Vlv2TbltDevicePkg/PlatformPkg.fdf | 5 +---- > > Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 5 +---- > > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + > > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > > 14 files changed, 9 insertions(+), 40 deletions(-) > > > > -- > > 2.18.0.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel