On Thu, Nov 01, 2018 at 06:03:22AM +0000, Zhang, Shenglei wrote: > Hi Leif, > > Thanks for your comments. Actually there is a cover letter. > https://lists.01.org/pipermail/edk2-devel/2018-October/031666.html
Ah, I missed that one since I was on cc on the rest of the set, but not the cover letter. > It may not be needed to rework but I 'll push the patches in order according > to > the comments you mentioned. If you do that: Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org> (After the November stable tag has been made.) Regards, Leif > Thanks, > Shenglei > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Wednesday, October 31, 2018 7:02 PM > > To: Zhang, Shenglei <shenglei.zh...@intel.com> > > Cc: edk2-devel@lists.01.org; Andrew Fish <af...@apple.com>; Laszlo Ersek > > <ler...@redhat.com>; Kinney, Michael D <michael.d.kin...@intel.com> > > Subject: Re: [PATCH 1/3] Maintainers.txt: Remove EdkShellPkg and > > EkdShellBinPkg > > > > Hi Shenglei, > > > > I am happy with this change, but I think the deletion from > > Maintainers.txt should come last (as 3/3). > > Could you rework and resubmit, and add a cover letter (0/3)? > > > > Best Regards, > > > > Leif > > > > On Wed, Oct 31, 2018 at 02:05:23PM +0800, shenglei wrote: > > > Given that EdkShellPkg and EkdShellBinPkg will be removed, > > > information about them in Maintainers.txt should also be > > > deleted. > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1107 > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1108 > > > > > > Cc: Andrew Fish <af...@apple.com> > > > Cc: Laszlo Ersek <ler...@redhat.com> > > > Cc: Leif Lindholm <leif.lindh...@linaro.org> > > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: shenglei <shenglei.zh...@intel.com> > > > --- > > > Maintainers.txt | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt > > > index 36c6689afd..98f104b674 100644 > > > --- a/Maintainers.txt > > > +++ b/Maintainers.txt > > > @@ -114,12 +114,6 @@ EdkCompatibilityPkg > > > W: > > https://github.com/tianocore/tianocore.github.io/wiki/EdkCompatibilityPkg > > > M: Liming Gao <liming....@intel.com> > > > > > > -EdkShellPkg, EdkShellBinPkg > > > -W: https://github.com/tianocore/tianocore.github.io/wiki/EdkShellPkg > > > -M: Ruiyu Ni <ruiyu...@intel.com> > > > -T: svn - https://svn.code.sf.net/p/efi-shell/code/trunk/Shell/ > > > -S: Obsolete (Use ShellPkg & ShellBinPkg instead) > > > - > > > EmbeddedPkg > > > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg > > > M: Leif Lindholm <leif.lindh...@linaro.org> > > > -- > > > 2.18.0.windows.1 > > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
