On Mon, Nov 12, 2018 at 05:11:55PM +0530, Chandni Cherukuri wrote: > Added ACPI tables and GUID name 'gSgiClarkHeliosAcpiTablesFileGuid' > for SGI-Clark.Helios platform. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Signed-off-by: Chandni Cherukuri <chandni.cheruk...@arm.com> > --- > Platform/ARM/SgiPkg/SgiPlatform.dec | 1 + > Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 + > Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 + > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/AcpiTables.inf | 58 +++++ > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 + > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Dbg2.aslc | 90 +++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Dsdt.asl | 262 > +++++++++++++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Fadt.aslc | 87 +++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Gtdt.aslc | 152 +++++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Iort.aslc | 106 ++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Madt.aslc | 266 > ++++++++++++++++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Mcfg.aslc | 61 +++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Spcr.aslc | 77 ++++++ > Platform/ARM/SgiPkg/AcpiTables/SgiClarkH/Ssdt.asl | 95 +++++++ > 14 files changed, 1258 insertions(+)
Oh, right, the "A" wasn't a platform revision, it was "Ares". And this is "Helios". Then please, ignore previous comments - the other one needs to be written out ARES/Ares and this one needs to be written out HELIOS/Helios. At which point we are in dire need of deduplication of these ACPI tables: - DBG2, SPCR and MCFG are already identical between the new platforms, and Sgi575 should be modified to the same format. (This set leaving Sgi575 on ACPI6.1 definitions while the new platforms go to 6.2 should be enough explanation for why we need to refactor this.) - IORT has no functional differences at all for A/H, and 575 differs only in (incorrectly) using __builtin_offsetof instead of the OFFSET_OF macro, and the ACPI version. - SSDT differs only in coding style issues and the platform name (which could come in through an include file). - GTDT and FADT are identical between A/H, and only ACPI version differences compared to 575. - DSDT and MADT, I accept, are different enough that a per-configuration source file makes sense. So please resubmit this as a set that: - Moves Dbg2.aslc, Fadt.aslc, Gtdt.aslc, Iort.aslc, Mcfg.aslc, Spcr.aslc and Ssdt.asl directly under Platform/ARM/SgiPkg/AcpiTables/. Moves AcpiTables.inf to Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf. Updates Platform/ARM/SgiPkg/SgiPlatform.dsc so that Sgi575 still builds. - Updates Sgi575 with whatever is required to pull the platform name in for SSDT. - Considers the COM1 name as mentioned in comment on previous patch. (I say considers: if I've misunderstood something, that one can be ignored.) - Brings in Ares and Helios platforms. (separate patches like now) - Brings in Ares and Helios ACPI tables, adding platform-specific Dsdt.asl and Madt.aslc under SgiClarkAres/SgiClarkHelios. (separate patches like now) With .inf files SgiClarkAresAcpiTables.inf and SgiClarkHeliosAcpiTables.inf. And once this is done, I no longer need to echo exactly the same comments I gave for the preceding patch, because everything will have alrady been addressed. Regards, Leif _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
