Please don't forget to change the copyright info when commit patch.
Reviewed-by: Eric Jin <eric....@intel.com>
-----Original Message-----
From: Lokesh B V <lokesh...@arm.com>
Sent: Tuesday, November 20, 2018 2:50 PM
To: edk2-devel@lists.01.org; supreeth.venkat...@arm.com; Jin, Eric
<eric....@intel.com>
Cc: Lokesh B V <lokesh...@arm.com>
Subject: [edk2-test][PATCH] SctPkg/Tools: Fix incorrect line ending detection
by GenBin tool
Some windows editors uses "\r\n" for line feed. While processing uefi testcase
info file, the GenBin tool logic to skip line feed doesn't consider the
presence of carraige return(\r) in line feed. So this results in incorrect
format error.
Signed-off-by: Lokesh B V <lokesh...@arm.com>
---
uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c
b/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c
index 61bb35b..ce271a1 100644
--- a/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c
+++ b/uefi-sct/SctPkg/Tools/Source/GenBin/GenBin.c
@@ -176,6 +176,7 @@ Trim (
for (Index1 = 0; Index1 < Length; Index1++) {
if ((String[Index1] != ' ' ) &&
(String[Index1] != '\t') &&
+ (String[Index1] != '\r') &&
(String[Index1] != '\n')) {
break;
}
@@ -193,6 +194,7 @@ Trim (
for (Index1 = 0; Index1 < Length; Index1++) {
if ((String[Length - 1 - Index1] != ' ' ) &&
(String[Length - 1 - Index1] != '\t') &&
+ (String[Length - 1 - Index1] != '\r') &&
(String[Length - 1 - Index1] != '\n')) {
break;
}
--
2.7.4
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
