On Tue Nov 27, 2018 at 01:08:33PM +0100, Ard Biesheuvel wrote:
> On Tue, 27 Nov 2018 at 11:44, Sughosh Ganu <sughosh.g...@arm.com> wrote:
> >
> >
> > Changes since v4:
> > Based on comments from Ard
> > - Removed now superfluous call to FreePages from MmCommunication.c
> > - Removed Chipset/AArch64.h header file from ArmMmuStandaloneMmLib.c
> >
> > Changes since v3:
> > Based on review comments from Ard, moved the MMU attribute changing
> > functions for StandaloneMM image into a new library class.
> >
> > Moved the addition of memory space used as a MM_COMMUNICATE buffer to
> > memory type 'EfiGcdMemoryTypeReserved' and removed the call to
> > AllocatgePages.
> >
> > Changes since v2:
> > Based on review comments from Ard, moved the memory attribute updation
> > changes out of DebugPeCoffExtraActionLib into an extra action library
> > added in StandaloneMM package. The patch for setting the memory
> > attributes, now under StandaloneMmPkg directory, will be submitted
> > separately from this series.
> >
> > Changes since v1: Handled review comments from Leif
> >
> >
> > Achin Gupta (4):
> > ArmPkg: Add PCDs needed for MM communication driver.
> > ArmPkg/Drivers: Add EFI_MM_COMMUNICATION_PROTOCOL DXE driver.
> > ArmPkg/Include: Add MM interface SVC return codes.
> > ArmPkg/ArmMmuLib: Add MMU Library suitable for use in S-EL0.
> >
> > Sughosh Ganu (1):
> > ArmPkg/Include: Fix the SPM version SVC ID
> >
>
> Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
>
> Pushed as 13d5d0a56e48..eed947be0b05
>
> Thanks! I'm very happy we will finally have the pieces in place to
> implement UEFI secure boot on ARM in a sane way.
Thanks a lot for the review and for applying the patches Ard!
-sughosh
>
> > ArmPkg/ArmPkg.dec
> >
> > | 4 +
> > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
> >
> > | 56 +++
> >
> > ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.inf
> > => ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf | 23 +-
> > ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h
> >
> > | 28 ++
> > ArmPkg/Include/IndustryStandard/ArmMmSvc.h
> >
> > | 9 +-
> > ArmPkg/Include/Library/{ArmMmuLib.h => StandaloneMmMmuLib.h}
> >
> > | 38 +-
> > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
> >
> > | 372 ++++++++++++++++++++
> > ArmPkg/Library/StandaloneMmMmuLib/Aarch64/ArmMmuStandaloneMmLib.c
> >
> > | 184 ++++++++++
> > 8 files changed, 669 insertions(+), 45 deletions(-)
> > create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
> > copy
> > ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/XenArmGenericTimerVirtCounterLib.inf
> > => ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf (56%)
> > create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h
> > copy ArmPkg/Include/Library/{ArmMmuLib.h => StandaloneMmMmuLib.h} (55%)
> > create mode 100644 ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
> > create mode 100644
> > ArmPkg/Library/StandaloneMmMmuLib/Aarch64/ArmMmuStandaloneMmLib.c
> >
> > --
> > 2.7.4
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
