On 28/11/18 15:33, Ard Biesheuvel wrote: > Derive the size of the GCD memory space map directly from the CPU's > information registers rather than from the PcdPrePiCpuMemorySize PCD, > which will be removed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > ArmPkg/Drivers/CpuPei/CpuPei.inf | 1 - > ArmPkg/Drivers/CpuPei/CpuPei.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ArmPkg/Drivers/CpuPei/CpuPei.inf > b/ArmPkg/Drivers/CpuPei/CpuPei.inf > index eafccd600983..dcea012fd8f9 100644 > --- a/ArmPkg/Drivers/CpuPei/CpuPei.inf > +++ b/ArmPkg/Drivers/CpuPei/CpuPei.inf > @@ -50,7 +50,6 @@ [Guids] > gArmMpCoreInfoGuid > > [FixedPcd] > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > [Depex] > diff --git a/ArmPkg/Drivers/CpuPei/CpuPei.c b/ArmPkg/Drivers/CpuPei/CpuPei.c > index d54f42acfcc8..e63519ff6481 100644 > --- a/ArmPkg/Drivers/CpuPei/CpuPei.c > +++ b/ArmPkg/Drivers/CpuPei/CpuPei.c > @@ -73,7 +73,7 @@ InitializeCpuPeim ( > ArmEnableBranchPrediction (); > > // Publish the CPU memory and io spaces sizes
This comment is misleading, maybe 'sizes' -> 'addressable bits'? (not related to this series) > - BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize)); > + BuildCpuHob (ArmGetPhysicalAddressBits (), PcdGet8 (PcdPrePiCpuIoSize)); Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > // Only MP Core platform need to produce gArmMpCoreInfoPpiGuid > Status = PeiServicesLocatePpi (&gArmMpCoreInfoPpiGuid, 0, NULL, > (VOID**)&ArmMpCoreInfoPpi); > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
