On 12/13/18 09:34, Shenglei Zhang wrote: > Add two public functions, CharToUpper and AsciiToUpper. > InternalCharToUpper and InternalBaseLibAsciiToUpper have the same > functions as CharToUpper and AsciiToUpper, but they are internal ones. > So the internal ones are removed and replace them with public ones > in other places. > https://bugzilla.tianocore.org/show_bug.cgi?id=1369 > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > --- > MdePkg/Include/Library/BaseLib.h | 40 +++++++++++++++++++++ > MdePkg/Library/BaseLib/BaseLibInternals.h | 42 ----------------------- > MdePkg/Library/BaseLib/SafeString.c | 8 ++--- > MdePkg/Library/BaseLib/String.c | 35 ++++--------------- > 4 files changed, 51 insertions(+), 74 deletions(-)
I have no comment on the code, but please change the subject line to: MdePkg/BaseLib: introduce CharToUpper() and AsciiToUpper() publicly or something similar. Thanks, Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
