Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu
> -----Original Message----- > From: Zhang, Shenglei > Sent: Tuesday, December 25, 2018 4:17 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J; Wu, Hao A; Ni, Ruiyu; Zeng, Star > Subject: [PATCH v4 1/7] MdeModulePkg/EbcDebugger: Change function > names > > Change UnicodeToUpper to InternalUnicodeToUpper. > Change AsciiToUpper to InternalAsciiToUpper. > These changes are committed for bisectability, or build failure will > occur when 2/7 is applied. Because the introduced function names in > 2/7 are the same as ones in EdbSupporting.c. > https://bugzilla.tianocore.org/show_bug.cgi?id=1369 > > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Hao Wu <hao.a...@intel.com> > Cc: Ruiyu Ni <ruiyu...@intel.com> > Cc: Star Zeng <star.z...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> > --- > .../Universal/EbcDxe/EbcDebugger/EdbSupportString.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git > a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > index 78a0559079..02e1876ffa 100644 > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > @@ -316,7 +316,7 @@ AsciiAtoi ( > **/ > STATIC > CHAR16 > -UnicodeToUpper ( > +InternalUnicodeToUpper ( > IN CHAR16 Chr > ) > { > @@ -332,7 +332,7 @@ UnicodeToUpper ( > **/ > STATIC > CHAR8 > -AsciiToUpper ( > +InternalAsciiToUpper ( > IN CHAR8 Chr > ) > { > @@ -390,12 +390,12 @@ StriCmp ( > ) > { > while ((*String != L'\0') && > - (UnicodeToUpper (*String) == UnicodeToUpper (*String2))) { > + (InternalUnicodeToUpper (*String) == InternalUnicodeToUpper > (*String2))) { > String++; > String2++; > } > > - return UnicodeToUpper (*String) - UnicodeToUpper (*String2); > + return InternalUnicodeToUpper (*String) - InternalUnicodeToUpper > (*String2); > } > > /** > @@ -418,12 +418,12 @@ StriCmpUnicodeAndAscii ( > ) > { > while ((*String != L'\0') && > - (UnicodeToUpper (*String) == (CHAR16)AsciiToUpper (*String2))) { > + (InternalUnicodeToUpper (*String) == (CHAR16)InternalAsciiToUpper > (*String2))) { > String++; > String2++; > } > > - return UnicodeToUpper (*String) - (CHAR16)AsciiToUpper (*String2); > + return InternalUnicodeToUpper (*String) - (CHAR16)InternalAsciiToUpper > (*String2); > } > > /** > -- > 2.18.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
