On Tue, 8 Jan 2019 at 02:54, Laszlo Ersek <ler...@redhat.com> wrote: > > On 01/07/19 19:08, Laszlo Ersek wrote: > > On 01/07/19 13:15, Gao, Liming wrote: > >> Laszlo: > >> This patch set is good to me. Reviewed-by: Liming Gao > >> <liming....@intel.com> > > > > Many thanks to everyone for the quick reviews! > > > >> Besides this patch set, I suggest to let GCC48/GCC49/GCC5 refer to the > >> common GCC_ flags. After I remove ELFGCC/UNIXGCC/CYGGCC tool chain, I will > >> update GCC_ flags to be same to current GCC48_ flags, then remove GCC48_ > >> flag definition. > > > > Sounds good to me, thanks. IIRC I actually looked into calling that > > stuff just GCC_, but I seem to remember that the subject macros were > > already defined for other purposes. Once you eliminate > > ELFGCC/UNIXGCC/CYGGCC, hopefully all those macros can be collapsed. > > > > For this series, I plan to go through the feedback tags in detail, > > shortly, and push the series if everything is sufficiently approved. > > That appears to be the case, so I've pushed the series: commit range > 46f4c9677c61..7423ba9d499b. >
Thanks a lot for this to the both of you. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
