Thanks Liming. I have files BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1444 to update UEFI drivers to use new APIs. I have not assigned it to anyone as there are many drivers across packages that need to be looked at. I would try to fix the ones I hit an issue with.
Over the weekend Siyuan approved the patch from PATCH v2 which is exactly same as in PATCH v4. Thanks Ashish -----Original Message----- From: Gao, Liming <liming....@intel.com> Sent: Thursday, January 10, 2019 8:23 AM To: Ashish Singhal <ashishsin...@nvidia.com>; Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org Cc: Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com> Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol uninstallation Ashish: The MdePkg change is good to me. Reviewed-by: Liming Gao <liming....@intel.com> Please help submit another BZ to update UefiDriver to uninstall protocol when failure with new APIs. If Siyuan/Jiaxin has no other comments, I will help push this patch set. Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ashish Singhal > Sent: Thursday, January 10, 2019 9:19 AM > To: Kinney, Michael D <michael.d.kin...@intel.com>; > edk2-devel@lists.01.org > Cc: Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin > <jiaxin...@intel.com>; Gao, Liming <liming....@intel.com> > Subject: Re: [edk2] [PATCH v4 0/2] Provide UEFILib functions for > protocol uninstallation > > Thanks Mike. Hope to see the patches merged soon. Please let me know if you > want me to file the BZ. > > Hi Liming, > > Please let me know if you need me to take care of anything in the patch > before you push it. > > Hi Siyuan/Jiaxin, > > I think you reviewed the changes in PATCH v2 which is same as in PATCH v4. > Please let me know if you have any issues with this going in. > > Thanks > Ashish > > -----Original Message----- > From: Kinney, Michael D <michael.d.kin...@intel.com> > Sent: Wednesday, January 9, 2019 5:56 PM > To: Ashish Singhal <ashishsin...@nvidia.com>; edk2-devel@lists.01.org; > Kinney, Michael D <michael.d.kin...@intel.com> > Cc: Gao, Liming <liming....@intel.com>; Fu, Siyuan > <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com> > Subject: RE: [PATCH v4 0/2] Provide UEFILib functions for protocol > uninstallation > > Hi Ashish, > > This V4 version of the patch produces the expected size results for platform > and driver builds. > > There are some very minor issues with some extra carriage returns, but > those can be handled by Liming when the patch series is committed. > > I may be good to have an additional BZ to use these new APIs from all > UEFI Driver Model drivers that have failure paths in their entry point or > support the unload feature. > Those updates can be done later. > > Thanks, > > Mike > > > -----Original Message----- > > From: Ashish Singhal [mailto:ashishsin...@nvidia.com] > > Sent: Wednesday, January 9, 2019 12:59 PM > > To: edk2-devel@lists.01.org > > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > > <liming....@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin > > <jiaxin...@intel.com>; Ashish Singhal <ashishsin...@nvidia.com> > > Subject: [PATCH v4 0/2] Provide UEFILib functions for protocol > > uninstallation > > > > An issue was seen in IScsiDxe in NetworkPkg where driver cleanup > > after initialization failure was not done right. Bug 1428 was filed > > in this regard. > > As per discussions with Mike, it was also discussed that having > > UEFILib provide protocol uninstallation abstraction would help to > > avoid these issues in the future. Bug 1429 was found to track this. > > These 2 patches > > take care of this. > > > > > > Ashish Singhal (2): > > MdePkg/UefiLib: Abstract driver model protocol uninstallation > > NetworkPkg/IScsiDxe: Use UEFILib APIs to uninstall protocols. > > > > MdePkg/Include/Library/UefiLib.h | 103 ++++ > > MdePkg/Library/UefiLib/UefiDriverModel.c | 972 > > ++++++++++++++++++++++++++++++- > > NetworkPkg/IScsiDxe/IScsiDriver.c | 31 +- > > 3 files changed, 1085 insertions(+), 21 deletions(-) > > > > -- > > 2.7.4 > > ---------------------------------------------------------------------- > ------------- This email message is for the sole use of the intended > recipient(s) and may contain confidential information. Any > unauthorized review, use, disclosure or distribution is prohibited. > If you are not the intended recipient, please contact the sender by > reply email and destroy all copies of the original message. > ---------------------------------------------------------------------- > ------------- _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
