On Tue, Jan 15, 2019 at 07:19:04AM +0100, Marcin Wojtas wrote: > > > + if (MmioRead32 (BaseAddress + MV_GPIO_OUT_EN_REG) & (1 << GpioPin)) { > > > + *Mode = GPIO_MODE_INPUT; > > > + } else { > > > + if (MmioRead32 (BaseAddress + MV_GPIO_DATA_IN_REG) & (1 << GpioPin)) > > > { > > > + *Mode = GPIO_MODE_OUTPUT_1; > > > + } else { > > > + *Mode = GPIO_MODE_OUTPUT_0; > > > > Ah, right, it's the change to EMBEDDED_GPIO that means we have two > > output modes to return instead of just input or output. > > Could I just ask that you're a bit more explicit about such things in > > the cover letter? Would have saved me a couple of minutes of head > > scratching. > > Well, in the cover letter I wrote: > "The biggest change is dropping custom GPIO protocol and start using > the generic EMBEDDED_GPIO with all its types." > > And in the commit log of both drivers: > "The new driver implements a generic EMBEDDED_GPIO protocol." > > Wasn't it explicit enough? :)
I mean, it's fine - you've technically given all the information needed to deduce that. But it does sort of imply that the reader knows all EDK2 interfaces by heart. And I'm not quite there. / Leif _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel