Reviewed-by: Qian Yi <yi.q...@intel.com> Thanks Qian Yi
> -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, January 17, 2019 1:45 AM > To: Gao, Liming <liming....@intel.com>; Qian, Yi <yi.q...@intel.com> > Cc: edk2-devel@lists.01.org; Sun, Zailiang <zailiang....@intel.com>; Laszlo > Ersek <ler...@redhat.com>; Leif Lindholm <leif.lindh...@linaro.org>; > Kinney, Michael D <michael.d.kin...@intel.com>; Wang, Jian J > <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Jagadeesh Ujja > <jagadeesh.u...@arm.com>; Achin Gupta <achin.gu...@arm.com>; > Thomas Panakamattam Abraham <thomas.abra...@arm.com>; Sami > Mujawar <sami.muja...@arm.com>; Zeng, Star <star.z...@intel.com> > Subject: Re: [PATCH v2 04/17] Vlv2TbltDevicePkg: add MmServicesTableLib > resolution > > (add Yi as well) > > On Wed, 16 Jan 2019 at 16:14, Gao, Liming <liming....@intel.com> wrote: > > > > Zailiang: > > Could you help review this change? > > > > > -----Original Message----- > > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > > Sent: Monday, January 14, 2019 9:28 PM > > > To: edk2-devel@lists.01.org > > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Laszlo Ersek > > > <ler...@redhat.com>; Leif Lindholm <leif.lindh...@linaro.org>; > > > Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > > > <liming....@intel.com>; Wang, Jian J <jian.j.w...@intel.com>; Wu, > > > Hao A <hao.a...@intel.com>; Jagadeesh Ujja > <jagadeesh.u...@arm.com>; > > > Achin Gupta <achin.gu...@arm.com>; Thomas Panakamattam Abraham > > > <thomas.abra...@arm.com>; Sami Mujawar > <sami.muja...@arm.com>; Zeng, > > > Star <star.z...@intel.com> > > > Subject: [PATCH v2 04/17] Vlv2TbltDevicePkg: add MmServicesTableLib > > > resolution > > > > > > The SMM based FTW and variable drivers are going to depend on > > > MmServicesTableLib after a subsequent patch, so add a resolution for > > > it to various Vlv2TbltDevicePkg .dsc files. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > > --- > > > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + > > > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > > > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > > > 3 files changed, 3 insertions(+) > > > > > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > > b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > > index d43611550285..eb7c205a10a6 100644 > > > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > > @@ -406,6 +406,7 @@ [LibraryClasses.X64.DXE_CORE] !endif > > > > > > [LibraryClasses.X64.DXE_SMM_DRIVER] > > > + > > > + > MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTab > > > + leLib.inf > > > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesT > ableLib.inf > > > > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/S > mmReportStatusCodeLib.inf > > > > > > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMe > moryA > > > llocationLib.inf diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > > b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > > index a33816c4d18b..b2f0d73f6d05 100644 > > > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > > @@ -406,6 +406,7 @@ [LibraryClasses.IA32.DXE_CORE] !endif > > > > > > [LibraryClasses.IA32.DXE_SMM_DRIVER] > > > + > > > + > MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTab > > > + leLib.inf > > > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesT > ableLib.inf > > > > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/S > mmReportStatusCodeLib.inf > > > > > > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMe > moryA > > > llocationLib.inf diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > > b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > > index 1da1442c64c6..aa62c07f177b 100644 > > > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > > @@ -408,6 +408,7 @@ [LibraryClasses.X64.DXE_CORE] !endif > > > > > > [LibraryClasses.X64.DXE_SMM_DRIVER] > > > + > > > + > MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTab > > > + leLib.inf > > > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesT > ableLib.inf > > > > ReportStatusCodeLib|MdeModulePkg/Library/SmmReportStatusCodeLib/S > mmReportStatusCodeLib.inf > > > > > > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMe > moryA > > > llocationLib.inf > > > -- > > > 2.20.1 > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel