Reviewed-by: Bob Feng <bob.c.f...@intel.com>
-----Original Message-----
From: Fan, ZhijuX
Sent: Tuesday, January 15, 2019 5:14 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming <liming....@intel.com>; Feng, Bob C <bob.c.f...@intel.com>
Subject: [edk2][PATCH] BaseTools:The BuildOptionPcd value is wrong
In GenFds.py, Due to the second assignment, the value is wrong Its value should
a list, not a string.and this line is not required
Cc: Bob Feng <bob.c.f...@intel.com>
Cc: Liming Gao <liming....@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zhiju.Fan <zhijux....@intel.com>
---
BaseTools/Source/Python/GenFds/GenFds.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/BaseTools/Source/Python/GenFds/GenFds.py
b/BaseTools/Source/Python/GenFds/GenFds.py
index 77383d3378..2baee570ed 100644
--- a/BaseTools/Source/Python/GenFds/GenFds.py
+++ b/BaseTools/Source/Python/GenFds/GenFds.py
@@ -192,7 +192,6 @@ def GenFdsApi(FdsCommandDict, WorkSpaceDataBase=None):
else:
EdkLogger.error("GenFds", OPTION_MISSING, "Missing active
platform")
- GlobalData.BuildOptionPcd = FdsCommandDict.get("OptionPcd") if
FdsCommandDict.get("OptionPcd") else {}
GenFdsGlobalVariable.ActivePlatform =
PathClass(NormPath(ActivePlatform))
if FdsCommandDict.get("conf_directory"):
--
2.18.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
