That's actually not quite correct - we need this package to build on IA32. It's named rather unfortunately, since it's not the EDK2 StdLibC, but rather a package in this repository - see IntelUndiPkg/LibC. It contains the bare minimum of functionality required to fix missing 64- bit math/shifts on IA32 and missing memcpy/memset intrinsics. We can't prevent MSVC from yielding memcpy/memset either, so this was the nasty solution for build issues. You have included CompilerIntrinsicsLib for the same reason, too :)
I'm not aware of any X64/IA32 equivalent of your CompilerIntrinsicsLib, but I'd be happy to be proven wrong here. I'm off for the rest of the week - I'll continue with reviews and merging early next week. Thanks, Richard. On Wed, 2018-11-14 at 18:33 -0800, ard.biesheuvela wrote: > StdLibc should not be used in drivers (it has dependencies on Shell > protocols), but in fact, we don't appear to rely on it in the first > place, so just drop the reference. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel at linaro.org> > --- > IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > index beee8aa8134e..b5747565fbea 100644 > --- a/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > +++ b/IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf > @@ -132,7 +132,6 @@ GCC:*_*_*_CC_FLAGS = -DEFI32 > PrintLib > UefiLib > HiiLib > - StdLibC > > [LibraryClasses.X64] > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
