On 02/01/19 03:16, Bi, Dandan wrote: > Hi Nikita, > > I have one comment here, could you help to verify this patch series with VS > tool chain build before commit the patches?
(1) Nikita, when you post the v2 series, please push it to a public repo/branch of yours as wel. So that developers with access to the VS toolchain can test-build your work for us (assuming you can't build with those toolchains -- I know I can't). (2) A note on topic branches, in advance -- when you push an updated version, please don't force-push earlier versions; instead, push to a branch called <topic_branch>_v<n>. (3) Some more administrativa -- please register in the TianoCore Bugzilla at <https://bugzilla.tianocore.org/>, file a feature request for this work (Product := TianoCore Feature Requests), and please assign it to yourself. Status should be IN_PROGRESS. (4) The commit messages should reference the BZ. (5) I also prefer if every posting (the blurb of it) is mentioned separately in the bugzilla, in a new comment; with subject line and mailing list archive URL. That way people can easily re-trace the evolution of the feature months or years later, by going through the BZ. (6) This seems like an important feature; I think it should be mentioned in https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning#proposed-features Once we have a BZ, I can add an item to the list. (I'm not exactly sure how "editable" the wiki is to new developers. We can figure that out later.) Thanks, Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Nikita Leshenko >> Sent: Thursday, January 31, 2019 6:07 PM >> To: edk2-devel@lists.01.org >> Cc: liran.a...@oracle.com >> Subject: [edk2] [PATCH 01/14] OvmfPkg/MptScsiDxe: Create empty driver >> >> In preparation for implementing LSI Fusion MPT SCSI devices, create a basic >> scaffolding for a driver. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Nikita Leshenko <nikita.leshche...@oracle.com> >> Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> >> Reviewed-by: Aaron Young <aaron.yo...@oracle.com> >> Reviewed-by: Liran Alon <liran.a...@oracle.com> >> --- >> OvmfPkg/MptScsiDxe/MptScsi.c | 30 ++++++++++++++++++++++++++++ >> OvmfPkg/MptScsiDxe/MptScsiDxe.inf | 33 >> +++++++++++++++++++++++++++++++ >> OvmfPkg/OvmfPkgIa32.dsc | 1 + >> OvmfPkg/OvmfPkgIa32.fdf | 1 + >> OvmfPkg/OvmfPkgIa32X64.dsc | 1 + >> OvmfPkg/OvmfPkgIa32X64.fdf | 1 + >> OvmfPkg/OvmfPkgX64.dsc | 1 + >> OvmfPkg/OvmfPkgX64.fdf | 1 + >> 8 files changed, 69 insertions(+) >> create mode 100644 OvmfPkg/MptScsiDxe/MptScsi.c create mode 100644 >> OvmfPkg/MptScsiDxe/MptScsiDxe.inf >> >> diff --git a/OvmfPkg/MptScsiDxe/MptScsi.c >> b/OvmfPkg/MptScsiDxe/MptScsi.c new file mode 100644 index >> 0000000000..73a693741d >> --- /dev/null >> +++ b/OvmfPkg/MptScsiDxe/MptScsi.c >> @@ -0,0 +1,30 @@ >> +/** @file >> + >> + This driver produces Extended SCSI Pass Thru Protocol instances for >> + LSI Fusion MPT SCSI devices. >> + >> + Copyright (C) 2018, Oracle and/or its affiliates. All rights reserved. >> + >> + This program and the accompanying materials are licensed and made >> + available under the terms and conditions of the BSD License which >> + accompanies this distribution. The full text of the license may be >> + found at http://opensource.org/licenses/bsd-license.php >> + >> + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" >> BASIS, >> + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER >> EXPRESS OR IMPLIED. >> + >> +**/ >> + >> +// >> +// Entry Point >> +// >> + >> +EFI_STATUS >> +EFIAPI >> +MptScsiEntryPoint ( >> + IN EFI_HANDLE ImageHandle, >> + IN EFI_SYSTEM_TABLE *SystemTable >> + ) >> +{ >> + return EFI_UNSUPPORTED; >> +} >> diff --git a/OvmfPkg/MptScsiDxe/MptScsiDxe.inf >> b/OvmfPkg/MptScsiDxe/MptScsiDxe.inf >> new file mode 100644 >> index 0000000000..c558d78034 >> --- /dev/null >> +++ b/OvmfPkg/MptScsiDxe/MptScsiDxe.inf >> @@ -0,0 +1,33 @@ >> +## @file >> +# This driver produces Extended SCSI Pass Thru Protocol instances for # >> +LSI Fusion MPT SCSI devices. >> +# >> +# Copyright (C) 2018, Oracle and/or its affiliates. All rights reserved. >> +# >> +# This program and the accompanying materials are licensed and made >> +available # under the terms and conditions of the BSD License which >> +accompanies this # distribution. The full text of the license may be >> +found at # http://opensource.org/licenses/bsd-license.php >> +# >> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" >> BASIS, >> +WITHOUT # WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER >> EXPRESS OR IMPLIED. >> +# >> +## >> + >> +[Defines] >> + INF_VERSION = 0x00010005 >> + BASE_NAME = MptScsiDxe >> + FILE_GUID = 2B3DB5DD-B315-4961-8454-0AFF3C811B19 >> + MODULE_TYPE = UEFI_DRIVER >> + VERSION_STRING = 1.0 >> + ENTRY_POINT = MptScsiEntryPoint >> + >> +[Sources] >> + MptScsi.c >> + >> +[Packages] >> + MdePkg/MdePkg.dec >> + OvmfPkg/OvmfPkg.dec >> + >> +[LibraryClasses] >> + UefiDriverEntryPoint >> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index >> aee19b75d7..52458859b6 100644 >> --- a/OvmfPkg/OvmfPkgIa32.dsc >> +++ b/OvmfPkg/OvmfPkgIa32.dsc >> @@ -708,6 +708,7 @@ >> OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf >> OvmfPkg/XenBusDxe/XenBusDxe.inf >> OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf >> + OvmfPkg/MptScsiDxe/MptScsiDxe.inf >> MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >> >> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCoun >> terRuntimeDxe.inf >> MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf index >> e013099136..73e36636e0 100644 >> --- a/OvmfPkg/OvmfPkgIa32.fdf >> +++ b/OvmfPkg/OvmfPkgIa32.fdf >> @@ -233,6 +233,7 @@ INF OvmfPkg/VirtioRngDxe/VirtioRng.inf >> INF OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf >> INF OvmfPkg/XenBusDxe/XenBusDxe.inf >> INF OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf >> +INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf >> >> !if $(SECURE_BOOT_ENABLE) == TRUE >> INF >> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi >> gDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc >> index 90cbd8e341..d8ea2addb2 100644 >> --- a/OvmfPkg/OvmfPkgIa32X64.dsc >> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc >> @@ -717,6 +717,7 @@ >> OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf >> OvmfPkg/XenBusDxe/XenBusDxe.inf >> OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf >> + OvmfPkg/MptScsiDxe/MptScsiDxe.inf >> MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >> >> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCoun >> terRuntimeDxe.inf >> MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf >> diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf >> index afaa334384..e22a223e7e 100644 >> --- a/OvmfPkg/OvmfPkgIa32X64.fdf >> +++ b/OvmfPkg/OvmfPkgIa32X64.fdf >> @@ -234,6 +234,7 @@ INF OvmfPkg/VirtioRngDxe/VirtioRng.inf >> INF OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf >> INF OvmfPkg/XenBusDxe/XenBusDxe.inf >> INF OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf >> +INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf >> >> !if $(SECURE_BOOT_ENABLE) == TRUE >> INF >> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi >> gDxe.inf >> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index >> 83d16eb00b..daf03cd1b5 100644 >> --- a/OvmfPkg/OvmfPkgX64.dsc >> +++ b/OvmfPkg/OvmfPkgX64.dsc >> @@ -715,6 +715,7 @@ >> OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf >> OvmfPkg/XenBusDxe/XenBusDxe.inf >> OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf >> + OvmfPkg/MptScsiDxe/MptScsiDxe.inf >> MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >> >> MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCoun >> terRuntimeDxe.inf >> MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf >> diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf index >> afaa334384..e22a223e7e 100644 >> --- a/OvmfPkg/OvmfPkgX64.fdf >> +++ b/OvmfPkg/OvmfPkgX64.fdf >> @@ -234,6 +234,7 @@ INF OvmfPkg/VirtioRngDxe/VirtioRng.inf >> INF OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf >> INF OvmfPkg/XenBusDxe/XenBusDxe.inf >> INF OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf >> +INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf >> >> !if $(SECURE_BOOT_ENABLE) == TRUE >> INF >> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi >> gDxe.inf >> -- >> 2.20.1 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
