On 02/07/19 15:59, Philippe Mathieu-Daudé wrote: > On 2/7/19 2:04 PM, Ryszard Knop wrote: >> Hi Philippe, Antoine, >> >> On Wed, 2019-02-06 at 23:30 +0100, Philippe Mathieu-Daudé wrote: >>> Hi Antoine, >>> >>> On 2/6/19 6:24 PM, Antoine Coeur wrote: >>>> Fix various typos in CryptoPkg. >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Coeur <co...@gmx.fr> >>>> --- >>>> CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c | 2 +- >>>> CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++-- >>>> 2 files changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c >>>> b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c >>>> index d63c23df09..540c5715cb 100644 >>>> --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c >>>> +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptTs.c >>>> @@ -142,7 +142,7 @@ IMPLEMENT_ASN1_FUNCTIONS (TS_TST_INFO) >>>> @param[in] Asn1Time Pointer to the ASN.1 >>>> GeneralizedTime to be converted. >>>> @param[out] SigningTime Return the corresponding EFI Time. >>>> >>>> - @retval TRUE The time convertion succeeds. >>>> + @retval TRUE The time conversion succeeds. >>> >>> The typos are indeed fixed, so: >>> Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> >>> >>> However reading this description makes me suspicious, I'd have >>> written >>> "The time convertion succeeded.", but I'm not native English speaker >>> so >>> I'll let someone with more insurance opinate. >> >> I'm not a native speaker either, but I'd write "conversion" as well. >> (Like revert -> reversion, subvert -> subversion, avert -> aversion, >> and so on.) > > Oops, I copy/pasted the wrong line :S > Indeed the correct word is "conversion", thanks for correcting me. > > My wonder is about what is the correct use between succeeds/succeeded, > I'd expect the following diff: > > - @retval TRUE The time convertion succeeds. > + @retval TRUE The time conversion succeeded.
Personally I'm fine either way, succeeds/succeeded. ... While the latter does look a bit improved, this patch is about typo fixes, not grammar fixes, so I guess we should stick with just conver[ts]ion for now. Just my 2 cents. Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
