On 03/11/19 02:15, Dong, Eric wrote: > Reviewed-by: Eric Dong <eric.d...@intel.com>
Thanks. I'm on the verge of email bankruptcy, so I'll skip this review. Laszlo >> -----Original Message----- >> From: Zhang, Shenglei >> Sent: Monday, March 11, 2019 8:55 AM >> To: edk2-devel@lists.01.org >> Cc: Dong, Eric <eric.d...@intel.com>; Ni, Ray <ray...@intel.com>; Laszlo >> Ersek <ler...@redhat.com> >> Subject: [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add the prompt and help >> information >> >> The prompt and help information are missing in UefiPkg.uni. >> https://bugzilla.tianocore.org/show_bug.cgi?id=1600 >> >> Cc: Eric Dong <eric.d...@intel.com> >> Cc: Ray Ni <ray...@intel.com> >> Cc: Laszlo Ersek <ler...@redhat.com> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Shenglei Zhang <shenglei.zh...@intel.com> >> --- >> UefiCpuPkg/UefiCpuPkg.uni | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index >> b132ce62cf..0e57b6ac98 100644 >> --- a/UefiCpuPkg/UefiCpuPkg.uni >> +++ b/UefiCpuPkg/UefiCpuPkg.uni >> @@ -114,6 +114,10 @@ >> >> #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_HELP >> #language en-US "Specifies stack size in bytes for each processor in SMM." >> >> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_PROMPT >> #language en-US "Processor stack size in SMM." >> + >> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStackSize_Help >> #language en-US "Specifies stack size in bytes for each processor in SMM." >> + >> #string >> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmApSyncTimeout_PROMPT >> #language en-US "AP synchronization timeout value in SMM" >> >> #string >> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmApSyncTimeout_HELP >> #language en-US "Specifies timeout value in microseconds for the BSP in >> SMM to wait for all APs to come into SMM." >> -- >> 2.18.0.windows.1 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
